Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 908943002: Port SkLazyPtr to new SkAtomics.h (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
*bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port SkLazyPtr to new SkAtomics.h No algorithmic changes. The new APIs let us avoid a few ugly trips through void*, and I've made the consume/acquire/release decision explicitly conditioned on TSAN. This should fix the attached bug, which is TSAN seeing us implementing the sk_consume_load() with a relaxed load, where we used to pass __ATOMIC_CONSUME to TSAN. This restores us to the status quo of a couple weeks ago, where we use relaxed loads (to avoid an extra dmb on ARM) for all setups except TSAN, who gets the logically correct memory order, consume. No public API changes. TBR=reed@google.com BUG=chromium:455606 Committed: https://skia.googlesource.com/skia/+/e72a80db3a05c78e65caf4c7cd24b73ebae74868

Patch Set 1 #

Patch Set 2 : unused #

Patch Set 3 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M include/core/SkAtomics.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkLazyPtr.h View 1 6 chunks +34 lines, -21 lines 0 comments Download
M include/core/SkPixelRef.h View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
This one's not exactly a rush, but it is a fix for a few TSAN-related ...
5 years, 10 months ago (2015-02-09 22:17:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908943002/40001
5 years, 10 months ago (2015-02-09 22:30:49 UTC) #5
bungeman-skia
lgtm
5 years, 10 months ago (2015-02-09 22:39:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908943002/40001
5 years, 10 months ago (2015-02-09 22:46:58 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:47:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e72a80db3a05c78e65caf4c7cd24b73ebae74868

Powered by Google App Engine
This is Rietveld 408576698