Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: test/mjsunit/harmony/classes-experimental.js

Issue 908883002: new classes: implement new.target passing to superclass constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix subclassing 'null' Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/runtime/runtime-object.cc ('K') | « src/variables.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Flags: --experimental-classes --harmony-classes 5 // Flags: --experimental-classes --harmony-classes
6 6
7 'use strict'; 7 'use strict';
8 8
9 class Base { 9 (function TestThisAccessRestriction() {
10 constructor(a, b) { 10 class Base {
11 let o = new Object(); 11 constructor(a, b) {
12 o.prp = a + b; 12 let o = new Object();
13 return o; 13 o.prp = a + b;
14 return o;
15 }
14 } 16 }
15 }
16 17
17 class Subclass extends Base { 18 class Subclass extends Base {
18 constructor(a, b) { 19 constructor(a, b) {
19 var exn; 20 var exn;
20 try { 21 try {
21 this.prp1 = 3; 22 this.prp1 = 3;
22 } catch (e) { 23 } catch (e) {
23 exn = e; 24 exn = e;
25 }
26 assertTrue(exn instanceof ReferenceError);
27 super(a, b);
28 assertSame(a + b, this.prp);
29 assertSame(undefined, this.prp1);
30 assertFalse(this.hasOwnProperty("prp1"));
31 return this;
24 } 32 }
25 assertTrue(exn instanceof ReferenceError);
26 super(a, b);
27 assertSame(a + b, this.prp);
28 assertSame(undefined, this.prp1);
29 assertFalse(this.hasOwnProperty("prp1"));
30 return this;
31 } 33 }
32 }
33 34
34 let b = new Base(1, 2); 35 let b = new Base(1, 2);
35 assertSame(3, b.prp); 36 assertSame(3, b.prp);
36 37
37 38
38 let s = new Subclass(2, -1); 39 let s = new Subclass(2, -1);
39 assertSame(1, s.prp); 40 assertSame(1, s.prp);
40 assertSame(undefined, s.prp1); 41 assertSame(undefined, s.prp1);
41 assertFalse(s.hasOwnProperty("prp1")); 42 assertFalse(s.hasOwnProperty("prp1"));
42 43
43 class Subclass2 extends Base { 44 class Subclass2 extends Base {
44 constructor(x) { 45 constructor(x) {
45 super(1,2); 46 super(1,2);
46 47
47 if (x < 0) return; 48 if (x < 0) return;
48 49
49 let called = false; 50 let called = false;
50 function tmp() { called = true; return 3; } 51 function tmp() { called = true; return 3; }
51 var exn = null; 52 var exn = null;
52 try { 53 try {
53 super(tmp(),4); 54 super(tmp(),4);
54 } catch(e) { exn = e; } 55 } catch(e) { exn = e; }
55 assertTrue(exn !== null); 56 assertTrue(exn !== null);
56 assertFalse(called); 57 assertFalse(called);
58 }
57 } 59 }
58 }
59 60
60 var s2 = new Subclass2(1); 61 var s2 = new Subclass2(1);
61 assertSame(3, s2.prp); 62 assertSame(3, s2.prp);
62 63
63 var s3 = new Subclass2(-1); 64 var s3 = new Subclass2(-1);
64 assertSame(3, s3.prp); 65 assertSame(3, s3.prp);
65 66
66 assertThrows(function() { Subclass.call(new Object(), 1, 2); }, TypeError); 67 assertThrows(function() { Subclass.call(new Object(), 1, 2); }, TypeError);
67 assertThrows(function() { Base.call(new Object(), 1, 2); }, TypeError); 68 assertThrows(function() { Base.call(new Object(), 1, 2); }, TypeError);
69
70 class BadSubclass extends Base {
71 constructor() {}
72 }
73
74 assertThrows(function() { new BadSubclass(); }, ReferenceError);
75 }());
76
77 (function TestPrototypeWiring() {
78 class Base {
79 constructor(x) {
80 this.foobar = x;
81 }
82 }
83
84 class Subclass extends Base {
85 constructor(x) {
86 super(x);
87 }
88 }
89
90 let s = new Subclass(1);
91 assertSame(1, s.foobar);
92 assertTrue(s.__proto__ === Subclass.prototype);
93
94 let s1 = new Subclass(1,2);
95 assertSame(1, s1.foobar);
96 assertTrue(s1.__proto__ === Subclass.prototype);
97
98 let s2 = new Subclass();
99 assertSame(undefined, s2.foobar);
100 assertTrue(s2.__proto__ === Subclass.prototype);
101 assertThrows(function() { Subclass(1); }, TypeError);
102 assertThrows(function() { Subclass(1,2,3,4); }, TypeError);
103
104 class Subclass2 extends Subclass {
105 constructor() {
106 super(5,6,7);
107 }
108 }
109
110 let s_2 = new Subclass2();
111 assertSame(5, s_2.foobar);
112 assertTrue(s_2.__proto__ === Subclass2.prototype);
113
114 class Subclass3 extends Base {
115 constructor(x,y) {
116 super(x+y);
117 }
118 }
119
120 let s_3 = new Subclass3(27,42-27);
121 assertSame(42, s_3.foobar);
122 assertTrue(s_3.__proto__ === Subclass3.prototype);
123 }());
124
125 (function TestArgumentsAccess() {
126 class Base {
127 constructor() {
128 assertEquals(2, arguments.length);
129 assertEquals(1, arguments[0]);
130 assertEquals(2, arguments[1]);
131 }
132 }
133
134 let b = new Base(1,2);
135
136 class Subclass extends Base {
137 constructor() {
138 assertEquals(2, arguments.length);
139 assertEquals(3, arguments[0]);
140 assertEquals(4, arguments[1]);
141 super(1,2);
142 }
143 }
144
145 let s = new Subclass(3,4);
146
147 class Subclass2 extends Base {
148 constructor(x,y) {
149 assertEquals(2, arguments.length);
150 assertEquals(3, arguments[0]);
151 assertEquals(4, arguments[1]);
152 super(1,2);
153 }
154 }
155
156 let s2 = new Subclass2(3,4);
157 }());
158
159
160 (function TestSublclassingBuiltins() {
161 class ExtendedUint8Array extends Uint8Array {
arv (Not doing code reviews) 2015/02/09 17:44:40 HOT!
162 constructor() {
163 super(10);
164 this[0] = 255;
165 this[1] = 0xFFA;
166 }
167 }
168
169 var eua = new ExtendedUint8Array();
170 assertEquals(10, eua.length);
171 assertEquals(10, eua.byteLength);
172 assertEquals(0xFF, eua[0]);
173 assertEquals(0xFA, eua[1]);
174 assertTrue(eua.__proto__ === ExtendedUint8Array.prototype);
arv (Not doing code reviews) 2015/02/09 17:44:40 Maybe a test with Object.prototype.toString to mak
Dmitry Lomov (no reviews) 2015/02/10 19:22:15 Done.
175 }());
176
177 (function TestSubclassingNull() {
178 let N = null;
179
180 class Foo extends N {
181 constructor(x,y) {
182 assertSame(1, x);
183 assertSame(2, y);
184 return new Object();
185 }
186 }
187
188 new Foo(1,2);
189 }());
OLDNEW
« src/runtime/runtime-object.cc ('K') | « src/variables.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698