Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 908863003: dart2js cps: Handle optional parameters in builder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed obsolete TODO Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 7a4499ac9434b2753abecc7fc76a2d4b8fe2fb8c..a2dc9e677271b78fe81a0469a625146d5c77c1c2 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -217,9 +217,10 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
AccessSemantics semantics) {
analyzer.Element staticElement = semantics.element;
dart2js.Element element = converter.convertElement(staticElement);
+ ir.Primitive receiver = irBuilder.buildLocalGet(element);
List<ir.Definition> arguments = visitArguments(node.argumentList);
- return irBuilder.buildLocalInvocation(
- element,
+ return irBuilder.buildFunctionExpressionInvocation(
+ receiver,
createSelectorFromMethodInvocation(
node.argumentList, node.methodName.name),
arguments);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | pkg/compiler/lib/src/js_backend/codegen/codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698