Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 908863003: dart2js cps: Handle optional parameters in builder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix static invoke Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index f883b9b9c38613e28b17b3cb0461338efe93a294..366f409a5402c530d03bb36588e4ee3a58807736 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -731,18 +731,9 @@ abstract class IrBuilder {
(k) => new ir.ConcatenateStrings(k, arguments));
}
- /// Create an invocation of [local] where the argument structure is defined
- /// by [selector] and the argument values are defined by [arguments].
- ir.Primitive buildLocalInvocation(LocalElement local,
- Selector selector,
- List<ir.Definition> arguments) {
- return _buildInvokeCall(buildLocalGet(local), selector, arguments);
- }
-
- /// Create an invocation of the [functionExpression] where the argument
- /// structure are defined by [selector] and the argument values are defined by
- /// [arguments].
- ir.Primitive buildFunctionExpressionInvocation(
+ /// Create an invocation of the `call` method of [functionExpression], where
+ /// the named arguments are given by [selector].
+ ir.Primitive buildCallInvocation(
ir.Primitive functionExpression,
Selector selector,
List<ir.Definition> arguments) {

Powered by Google App Engine
This is Rietveld 408576698