pkg/compiler/lib/src/compile_time_constants.dart - Issue 908863003: dart2js cps: Handle optional parameters in builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 908863003: dart2js cps: Handle optional parameters in builder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Unrevert + rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer2dart/lib/src/cps_generator.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/compile_time_constants.dart

diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart

index 5fb178d9b7de98e8a7fc15e865bebedec65e3b59..13d5d63a79b89bf19cacf169c01ea3fd5f2d7ffb 100644

--- a/pkg/compiler/lib/src/compile_time_constants.dart

+++ b/pkg/compiler/lib/src/compile_time_constants.dart

@@ -676,10 +676,10 @@ class CompileTimeConstantEvaluator extends Visitor<AstConstant> {

target.functionSignature.parameterCount,

new ErroneousAstConstant(context, node));

}

- return selector.makeArgumentsList2(arguments,

- target,

- compileArgument,

- compileDefaultValue);

+ return selector.makeArgumentsList(arguments,

+ target,

+ compileArgument,

+ compileDefaultValue);

}

AstConstant visitNewExpression(NewExpression node) {