dart2js cps: Handle optional parameters in builder.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 189 matching lines @@
       //   [Entity]s or add a specialized Tree-IR node for interceptor calls.
       registry.registerUseInterceptor();
       js.VariableUse interceptorLibrary = glue.getInterceptorLibrary();
       return js.propertyCall(interceptorLibrary, selector.name, arguments);
     } else {
       js.Expression elementAccess = glue.staticFunctionAccess(target);
       return new js.Call(elementAccess, arguments);
     }
   }
 
-  List<js.Expression> compileStaticArgumentList(
-      Selector selector,
-      Element target, /* TODO(karlklose): this should be the signature. */
-      List<tree_ir.Expression> arguments) {
-    return selector.makeArgumentsList(
-        target.implementation,
-        visitArguments(arguments),
-        compileConstant);
-  }

[asgerf, 2015/02/09 14:44:30]

Arguments with side effects would get reordered here, e.g:

foo(b: getB(), a: getA());
-->
foo(getA(), getB());

-
   @override
   js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) {
     checkStaticTargetIsValid(node, node.target);
 
     if (node.constant != null) return giveup(node);
     registry.registerInstantiatedClass(node.target.enclosingClass);
     Selector selector = node.selector;
     FunctionElement target = node.target;
-    List<js.Expression> arguments =
-        compileStaticArgumentList(selector, target, node.arguments);
+    List<js.Expression> arguments = visitArguments(node.arguments);
     return buildStaticInvoke(selector, target, arguments);
   }
 
   void registerMethodInvoke(tree_ir.InvokeMethod node) {
     Selector selector = node.selector;
     if (selector.isGetter) {
       registry.registerDynamicGetter(selector);
     } else if (selector.isSetter) {
       registry.registerDynamicSetter(selector);
     } else {
@@ skipping 31 matching lines @@
 
   @override
   js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) {
     checkStaticTargetIsValid(node, node.target);
 
     if (node.target is! FunctionElement) {
       giveup(node, 'static getters and setters are not supported.');
     }
     Selector selector = node.selector;
     FunctionElement target = node.target;
-    List<js.Expression> arguments =
-        compileStaticArgumentList(selector, target, node.arguments);
+    List<js.Expression> arguments = visitArguments(node.arguments);
     return buildStaticInvoke(selector, target, arguments);
   }
 
   @override
   js.Expression visitInvokeMethodDirectly(tree_ir.InvokeMethodDirectly node) {
     registry.registerDirectInvocation(node.target.declaration);
     if (node.target is ConstructorBodyElement) {
       // A constructor body cannot be overriden or intercepted, so we can
       // use the short form for this invocation.
       // TODO(asgerf): prevent name clash between constructor bodies.
@@ skipping 242 matching lines @@
   void visitSetField(tree_ir.SetField node) {
     js.PropertyAccess field =
         new js.PropertyAccess.field(
             visitExpression(node.object),
             glue.instanceFieldPropertyName(node.field));
     js.Assignment asn = new js.Assignment(field, visitExpression(node.value));
     accumulator.add(new js.ExpressionStatement(asn));
     visitStatement(node.next);
   }
 }