Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 908863002: Remove some busy-OSR loops from tests using %OptimizeOsr(). (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove some busy-OSR loops from tests using %OptimizeOsr(). R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/9030a2674ba6a1e1b3d9cc88299e2d5aebd22660 Cr-Commit-Position: refs/heads/master@{#26527}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M test/mjsunit/count-based-osr.js View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/regress/binop-in-effect-context-deopt.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/call-function-in-effect-context-deopt.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1118.js View 1 1 chunk +2 lines, -16 lines 0 comments Download
M test/mjsunit/regress/regress-2618.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-150545.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/regress/string-set-char-deopt.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 10 months ago (2015-02-09 13:12:11 UTC) #1
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/908863002/diff/1/test/mjsunit/regress/regress-1118.js File test/mjsunit/regress/regress-1118.js (right): https://codereview.chromium.org/908863002/diff/1/test/mjsunit/regress/regress-1118.js#newcode44 test/mjsunit/regress/regress-1118.js:44: // Optimization status (see runtime.cc): nit: ...
5 years, 10 months ago (2015-02-09 13:17:11 UTC) #2
titzer
https://codereview.chromium.org/908863002/diff/1/test/mjsunit/regress/regress-1118.js File test/mjsunit/regress/regress-1118.js (right): https://codereview.chromium.org/908863002/diff/1/test/mjsunit/regress/regress-1118.js#newcode44 test/mjsunit/regress/regress-1118.js:44: // Optimization status (see runtime.cc): On 2015/02/09 13:17:11, Michael ...
5 years, 10 months ago (2015-02-09 13:26:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908863002/20001
5 years, 10 months ago (2015-02-09 13:27:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 14:11:18 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 14:11:33 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9030a2674ba6a1e1b3d9cc88299e2d5aebd22660
Cr-Commit-Position: refs/heads/master@{#26527}

Powered by Google App Engine
This is Rietveld 408576698