Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 9088002: Revert "Revert the disk_cache change part of http://codereview.chromium.org/9035012" (Closed)

Created:
8 years, 11 months ago by James Hawkins
Modified:
8 years, 11 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Revert "Revert the disk_cache change part of http://codereview.chromium.org/9035012" The hanging test is unrelated to this change (it's merely tickled by a potential timing change). BUG=50346 TEST=none TBR=awong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M net/disk_cache/backend_impl.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
8 years, 11 months ago (2012-01-04 00:10:46 UTC) #1
awong
LGTM but add BUG=50346 +thakis for FYI
8 years, 11 months ago (2012-01-04 00:13:51 UTC) #2
Nico
8 years, 11 months ago (2012-01-04 00:14:55 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698