Add a compiled_resources.gyp for network_Ui and fix compiler errors.

chrome/browser/resources/chromeos/network_ui/network_ui.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var NetworkUI = (function() {
   'use strict';
 
   // Properties to display in the network state table. Each entry can be either
   // a single state field or an array of state fields. If more than one is
   // specified then the first non empty value is used.
@@ skipping 46 matching lines @@
       if (subobject)
         return getValueFromProperties(subobject, key2);
     }
     return properties[key];
   };
 
   /**
    * Creates a cell with a button for expanding a network state table row.
    *
    * @param {string} guid The GUID identifying the network.
-   * @return {DOMElement} The created td element that displays the given value.
+   * @return {!HTMLElement} The created td element that displays the given
+   *     value.
    */
   var createStateTableExpandButton = function(guid) {
-    var cell = document.createElement('td');
+    var cell = /** @type {!HTMLElement} */ (document.createElement('td'));
     cell.className = 'state-table-expand-button-cell';
     var button = document.createElement('button');
     button.addEventListener('click', function(event) {
-      toggleExpandRow(event.target, guid);
+      toggleExpandRow(/** @type {!HTMLElement} */ (event.target), guid);
     });
     button.className = 'state-table-expand-button';
     button.textContent = '+';
     cell.appendChild(button);
     return cell;
   };
 
   /**
    * Creates a cell in network state table.
    *
    * @param {string} value Content in the cell.
-   * @return {DOMElement} The created td element that displays the given value.
+   * @return {!HTMLElement} The created td element that displays the given
+   *     value.
    */
   var createStateTableCell = function(value) {
     var cell = document.createElement('td');
     cell.textContent = value || '';
-    return cell;
+    return /** @type {!HTMLElement} */ (cell);

[stevenjb, 2015/02/06 21:45:25]

Question: Why declare they type here instead of after cell = like in the other
methods?

[Jeremy Klein, 2015/02/07 00:21:45]

Done.

   };
 
   /**
    * Creates a row in the network state table.
    *
    * @param {Array} stateFields The state fields to use for the row.
    * @param {Object} state Property values for the network or favorite.
-   * @return {DOMElement} The created tr element that contains the network
+   * @return {!HTMLElement} The created tr element that contains the network
    *     state information.
    */
   var createStateTableRow = function(stateFields, state) {
-    var row = document.createElement('tr');
+    var row = /** @type {!HTMLElement} */ (document.createElement('tr'));
     row.className = 'state-table-row';
-    var guid = state.GUID;
+    var guid = state['GUID'];
     row.appendChild(createStateTableExpandButton(guid));
     for (var i = 0; i < stateFields.length; ++i) {
       var field = stateFields[i];
       var value = '';
       if (typeof field == 'string') {
         value = getValueFromProperties(state, field);
       } else {
         for (var j = 0; j < field.length; ++j) {
           value = getValueFromProperties(state, field[j]);
           if (value)
             break;
         }
       }
       if (field == 'GUID')
         value = value.slice(0, 8);
-      row.appendChild(createStateTableCell(value));
+      row.appendChild(createStateTableCell(/** @type {string} */ (value)));
     }
     return row;
   };
 
   /**
    * Creates a table for networks or favorites.
    *
    * @param {string} tablename The name of the table to be created.
    * @param {Array} stateFields The list of fields for the table.
    * @param {Array} states An array of network or favorite states.
    */
   var createStateTable = function(tablename, stateFields, states) {
     var table = $(tablename);
     var oldRows = table.querySelectorAll('.state-table-row');
     for (var i = 0; i < oldRows.length; ++i)
       table.removeChild(oldRows[i]);
     states.forEach(function(state) {
       table.appendChild(createStateTableRow(stateFields, state));
     });
   };
 
   /**
    * This callback function is triggered when visible networks are received.
    *
-   * @param {Array} data A list of network state information for each
+   * @param {Array} states A list of network state information for each
    *     visible network.
    */
   var onVisibleNetworksReceived = function(states) {
     createStateTable('network-state-table', NETWORK_STATE_FIELDS, states);
   };
 
   /**
    * This callback function is triggered when favorite networks are received.
    *
-   * @param {Object} data A list of network state information for each
+   * @param {!Array} states A list of network state information for each
    *     favorite network.
    */
   var onFavoriteNetworksReceived = function(states) {
     createStateTable('favorite-state-table', FAVORITE_STATE_FIELDS, states);
   };
 
   /**
    * Toggles the button state and add or remove a row displaying the complete
    * state information for a row.
    *
-   * @param {DOMElement} btn The button that was clicked.
+   * @param {!HTMLElement} btn The button that was clicked.
    * @param {string} guid GUID identifying the network.
    */
   var toggleExpandRow = function(btn, guid) {
     var cell = btn.parentNode;
-    var row = cell.parentNode;
+    var row = /** @type {!HTMLElement} */ (cell.parentNode);
     if (btn.textContent == '-') {
       btn.textContent = '+';
       row.parentNode.removeChild(row.nextSibling);
     } else {
       btn.textContent = '-';
       var expandedRow = createExpandedRow(guid, row);
       row.parentNode.insertBefore(expandedRow, row.nextSibling);
     }
   };
 
   /**
    * Creates the expanded row for displaying the complete state as JSON.
    *
-   * @param {Object} state Property values for the network or favorite.
-   * @param {DOMElement} baseRow The unexpanded row associated with the new row.
-   * @return {DOMElement} The created tr element for the expanded row.
+   * @param {string} guid The GUID identifying the network.
+   * @param {!HTMLElement} baseRow The unexpanded row associated with the new
+   *     row.
+   * @return {!HTMLElement} The created tr element for the expanded row.
    */
   var createExpandedRow = function(guid, baseRow) {
-    var expandedRow = document.createElement('tr');
+    var expandedRow = /** @type {!HTMLElement} */ (
+      document.createElement('tr'));
     expandedRow.className = 'state-table-row';
     var emptyCell = document.createElement('td');
     emptyCell.style.border = 'none';
     expandedRow.appendChild(emptyCell);
     var detailCell = document.createElement('td');
     detailCell.id = guid;
     detailCell.className = 'state-table-expanded-cell';
     detailCell.colSpan = baseRow.childNodes.length - 1;
     expandedRow.appendChild(detailCell);
     var showDetail = function(state, error) {
@@ skipping 12 matching lines @@
     } else {
       chrome.networkingPrivate.getProperties(guid, function(properties) {
         showDetail(properties, chrome.runtime.lastError); });
     }
     return expandedRow;
   };
 
   /**
    * Callback invoked by Chrome after a getShillProperties call.
    *
-   * @param {Object} properties The requested Shill properties. Will contain
+   * @param {Array} args The requested Shill properties. Will contain
    *     just the 'GUID' and 'ShillError' properties if the call failed.
    */
   var getShillPropertiesResult = function(args) {
     var properties = args.shift();
     var guid = properties['GUID'];
     if (!guid) {
       console.error('No GUID in getShillPropertiesResult');
       return;
     }
 
@@ skipping 19 matching lines @@
     chrome.networkingPrivate.getNetworks(
         {'networkType': 'All', 'configured': true}, onFavoriteNetworksReceived);
   };
 
   /**
    * Sets refresh rate if the interval is found in the url.
    */
   var setRefresh = function() {
     var interval = parseQueryParams(window.location)['refresh'];
     if (interval && interval != '')
-      setInterval(requestNetworks, parseInt(interval) * 1000);
+      setInterval(requestNetworks, parseInt(interval, 10) * 1000);
   };
 
   /**
    * Gets network information from WebUI.
    */
   document.addEventListener('DOMContentLoaded', function() {
     $('refresh').onclick = requestNetworks;
     setRefresh();
     requestNetworks();
   });
 
   return {
     getShillPropertiesResult: getShillPropertiesResult
   };
 })();