Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 908633002: Add a compiled_resources.gyp for network_Ui and fix compiler errors. (Closed)

Created:
5 years, 10 months ago by Jeremy Klein
Modified:
5 years, 10 months ago
Reviewers:
stevenjb, *Dan Beam
CC:
chromium-reviews, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a compiled_resources.gyp for network_Ui and fix compiler errors. BUG=456378 Committed: https://crrev.com/1f1f8082358c51053f65380218d6c343c4bbda3f Cr-Commit-Position: refs/heads/master@{#315398}

Patch Set 1 #

Patch Set 2 : Adding reviewers #

Total comments: 3

Patch Set 3 : Address stevenjb's comment. #

Total comments: 2

Patch Set 4 : Add a TODO to fix <(variables in transient extern deps." #

Patch Set 5 : Use the correct gyp comment format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
A chrome/browser/resources/chromeos/network_ui/compiled_resources.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.js View 1 2 10 chunks +23 lines, -19 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/compiled_resources.gyp View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Dan Beam
needs a bug= https://codereview.chromium.org/908633002/diff/20001/ui/webui/resources/js/compiled_resources.gyp File ui/webui/resources/js/compiled_resources.gyp (right): https://codereview.chromium.org/908633002/diff/20001/ui/webui/resources/js/compiled_resources.gyp#newcode40 ui/webui/resources/js/compiled_resources.gyp:40: 'externs': ['../../../../third_party/closure_compiler/externs/pending_compiler_externs.js'], so are you planning ...
5 years, 10 months ago (2015-02-06 21:33:52 UTC) #3
stevenjb
lgtm https://codereview.chromium.org/908633002/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.js File chrome/browser/resources/chromeos/network_ui/network_ui.js (right): https://codereview.chromium.org/908633002/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.js#newcode93 chrome/browser/resources/chromeos/network_ui/network_ui.js:93: return /** @type {!HTMLElement} */ (cell); Question: Why ...
5 years, 10 months ago (2015-02-06 21:45:25 UTC) #4
Jeremy Klein
On 2015/02/06 21:33:52, Dan Beam wrote: > needs a bug= > > https://codereview.chromium.org/908633002/diff/20001/ui/webui/resources/js/compiled_resources.gyp > File ...
5 years, 10 months ago (2015-02-06 21:46:25 UTC) #5
Jeremy Klein
Added BUG=. https://codereview.chromium.org/908633002/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.js File chrome/browser/resources/chromeos/network_ui/network_ui.js (right): https://codereview.chromium.org/908633002/diff/20001/chrome/browser/resources/chromeos/network_ui/network_ui.js#newcode93 chrome/browser/resources/chromeos/network_ui/network_ui.js:93: return /** @type {!HTMLElement} */ (cell); On ...
5 years, 10 months ago (2015-02-07 00:21:45 UTC) #6
Dan Beam
lgtm (fyi: compile's broken again) https://codereview.chromium.org/908633002/diff/40001/ui/webui/resources/js/compiled_resources.gyp File ui/webui/resources/js/compiled_resources.gyp (right): https://codereview.chromium.org/908633002/diff/40001/ui/webui/resources/js/compiled_resources.gyp#newcode32 ui/webui/resources/js/compiled_resources.gyp:32: 'depends': ['cr.js'], TODO(jlklein): get ...
5 years, 10 months ago (2015-02-09 20:21:03 UTC) #8
Jeremy Klein
https://codereview.chromium.org/908633002/diff/40001/ui/webui/resources/js/compiled_resources.gyp File ui/webui/resources/js/compiled_resources.gyp (right): https://codereview.chromium.org/908633002/diff/40001/ui/webui/resources/js/compiled_resources.gyp#newcode32 ui/webui/resources/js/compiled_resources.gyp:32: 'depends': ['cr.js'], On 2015/02/09 20:21:02, Dan Beam wrote: > ...
5 years, 10 months ago (2015-02-09 20:46:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908633002/80001
5 years, 10 months ago (2015-02-09 20:51:43 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-09 21:30:45 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:31:27 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/1f1f8082358c51053f65380218d6c343c4bbda3f
Cr-Commit-Position: refs/heads/master@{#315398}

Powered by Google App Engine
This is Rietveld 408576698