Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 908613002: Enable strict virtual specifier checks on Android. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
dcheng
Built cleanly a few minutes ago, so I'll be git cl landing this.
5 years, 10 months ago (2015-02-06 19:04:51 UTC) #2
dcheng
(Also, I'm not removing this yet because I need to finish cleaning up the internal ...
5 years, 10 months ago (2015-02-06 19:05:05 UTC) #3
Nico
lgtm I assume you figured out how to do an internal build, as to not ...
5 years, 10 months ago (2015-02-06 19:05:39 UTC) #4
dcheng
On 2015/02/06 at 19:05:39, thakis wrote: > lgtm > > I assume you figured out ...
5 years, 10 months ago (2015-02-06 19:15:50 UTC) #5
Nico
:-/ oh well. On Fri, Feb 6, 2015 at 11:15 AM, <dcheng@chromium.org> wrote: > On ...
5 years, 10 months ago (2015-02-06 19:16:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c75a0a8c21c8af479b5408b59e6463d0b9acf67 Cr-Commit-Position: refs/heads/master@{#315083}
5 years, 10 months ago (2015-02-06 19:16:51 UTC) #7
dcheng
5 years, 10 months ago (2015-02-06 19:17:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c75a0a8c21c8af479b5408b59e6463d0b9acf67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698