Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 908493004: Landing Recent QUIC Changes. (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng, alyssar, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Track the number of "early" frames received in a QUIC stream. This will help measure the amount of head of line blocking of the headers stream that QUIC sees. Merge internal change: 85643187 https://codereview.chromium.org/893323004/ Remove QUIC's ReceiveAlgorithmInterface now that it does nothing. No functionality change. Merge internal change: 85621906 https://codereview.chromium.org/908673002/ Fixing a bug where 0-round-trip connection establishment was conflated with zero-second-round-trip-time in faster. Chromium side change is only a comment change. Merge internal change: 85554888 https://codereview.chromium.org/904993004/ Remove FLAGS_quic_allow_silent_close. Merge internal change: 85387940 https://codereview.chromium.org/902243003/ Keep an instance of QuicAckFrame in QuicConnection in order to reduce memory allocations. Saves 1.5% of the CPU according to profiles. May be slightly more on clients. Merge internal change: 85351635 https://codereview.chromium.org/876313009/ Fix compile errors introduced when editing QuicFramerTest during the presubmit. Merge internal change: 85182632 https://codereview.chromium.org/905033002/ Move is_fec_packet from QuicPacket to SerializedPacket in order to allow QuicSerializedPacket to contain a QuicEncryptedPacket instead in a future CL. Merge internal change: 85181879 https://codereview.chromium.org/887243005/ R=rch@chromium.org Committed: https://crrev.com/ca5ac274170dd281e90a4d9a42aed11dfb60962d Cr-Commit-Position: refs/heads/master@{#315200}

Patch Set 1 #

Patch Set 2 : fix valgrind error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -390 lines) Patch
M net/net.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
D net/quic/congestion_control/receive_algorithm_interface.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/quic/congestion_control/receive_algorithm_interface.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D net/quic/congestion_control/tcp_receiver.h View 1 chunk +0 lines, -37 lines 0 comments Download
D net/quic/congestion_control/tcp_receiver.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D net/quic/congestion_control/tcp_receiver_test.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_config.cc View 2 chunks +1 line, -6 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 5 chunks +17 lines, -26 lines 0 comments Download
M net/quic/quic_connection_test.cc View 9 chunks +6 lines, -29 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 3 chunks +7 lines, -10 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 5 chunks +0 lines, -16 lines 0 comments Download
M net/quic/quic_packet_generator.h View 2 chunks +9 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 8 chunks +9 lines, -24 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +7 lines, -32 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M net/quic/quic_server.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 2 chunks +3 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
5 years, 10 months ago (2015-02-07 01:11:13 UTC) #1
ramant (doing other things)
On 2015/02/07 01:11:13, ramant wrote: Hi Ryan and Ian, Will be porting/merging AeadBaseDecrypter changes in ...
5 years, 10 months ago (2015-02-07 01:20:36 UTC) #2
Ryan Hamilton
lgtm
5 years, 10 months ago (2015-02-07 03:48:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908493004/40001
5 years, 10 months ago (2015-02-07 06:35:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-07 12:35:21 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 12:36:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca5ac274170dd281e90a4d9a42aed11dfb60962d
Cr-Commit-Position: refs/heads/master@{#315200}

Powered by Google App Engine
This is Rietveld 408576698