Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 908493002: Add a ComboboxModel and strings for the account chooser's "More" button. (Closed)

Created:
5 years, 10 months ago by dconnelly
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a ComboboxModel and strings for the account chooser's "More" button. BUG=448011 Committed: https://crrev.com/5f5ef2b44dbd5af4ba887fed507115430f1174fc Cr-Commit-Position: refs/heads/master@{#315332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/ui/passwords/account_chooser_more_combobox_model.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/passwords/account_chooser_more_combobox_model.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dconnelly
5 years, 10 months ago (2015-02-06 16:15:14 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-06 17:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908493002/1
5 years, 10 months ago (2015-02-09 16:23:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 17:29:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:29:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f5ef2b44dbd5af4ba887fed507115430f1174fc
Cr-Commit-Position: refs/heads/master@{#315332}

Powered by Google App Engine
This is Rietveld 408576698