Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 908483003: Temporarily disabling AppRTC test on windows. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disabling AppRTC test on windows. https://github.com/webrtc/apprtc/issues/48 BUG=455758 R=kjellander@chromium.org Committed: https://crrev.com/1511092cac89c527343c0c9ab4e0eb3ac1ba3762 Cr-Commit-Position: refs/heads/master@{#315028}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +8 lines, -1 line 1 comment Download

Messages

Total messages: 7 (1 generated)
phoglund_chromium
5 years, 10 months ago (2015-02-06 13:31:11 UTC) #1
kjellander_chromium
lgtm https://codereview.chromium.org/908483003/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/908483003/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode235 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:235: I usually skip a newline here.
5 years, 10 months ago (2015-02-06 13:32:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908483003/1
5 years, 10 months ago (2015-02-06 13:34:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 14:19:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1511092cac89c527343c0c9ab4e0eb3ac1ba3762 Cr-Commit-Position: refs/heads/master@{#315028}
5 years, 10 months ago (2015-02-06 14:21:06 UTC) #6
phoglund_chromium
5 years, 10 months ago (2015-02-10 11:35:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/906403008/ by phoglund@chromium.org.

The reason for reverting is: This test should now be fixed..

Powered by Google App Engine
This is Rietveld 408576698