Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 908463003: [Chromoting] Use platformIsMac instead of checking navigator.platform directly. (Closed)

Created:
5 years, 10 months ago by garykac
Modified:
5 years, 10 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use platformIsMac instead of checking navigator.platform directly. BUG= Committed: https://crrev.com/c768e43024e9f8c582cae3285078c2aa46f1e0c5 Cr-Commit-Position: refs/heads/master@{#315100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/app_remoting/js/loading_window.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
garykac
5 years, 10 months ago (2015-02-06 18:17:31 UTC) #2
Jamie
lgtm
5 years, 10 months ago (2015-02-06 18:25:03 UTC) #4
kelvinp
lgtm
5 years, 10 months ago (2015-02-06 19:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908463003/1
5 years, 10 months ago (2015-02-06 19:05:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 20:45:34 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 20:45:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c768e43024e9f8c582cae3285078c2aa46f1e0c5
Cr-Commit-Position: refs/heads/master@{#315100}

Powered by Google App Engine
This is Rietveld 408576698