Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: Source/core/frame/Frame.cpp

Issue 908453003: Blink changes to record interest rects for http://w3c.github.io/frame-timing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/Frame.cpp
diff --git a/Source/core/frame/Frame.cpp b/Source/core/frame/Frame.cpp
index 4f95ddfb6d8fea37c74c90f1e9df0369f3e741f3..1f5f159ab8b11121c048114cb3a73fa5c0fbd41b 100644
--- a/Source/core/frame/Frame.cpp
+++ b/Source/core/frame/Frame.cpp
@@ -53,6 +53,18 @@ namespace blink {
using namespace HTMLNames;
+namespace {
+
+int64_t generateFrameID()
+{
+ // Initialize to the current time to reduce the likelihood of generating
+ // identifiers that overlap with those from past/future browser sessions.
+ static int64_t next = static_cast<int64_t>(currentTime() * 1000000.0);
+ return ++next;
+}
+
+} // namespace
+
DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, frameCounter, ("Frame"));
Frame::~Frame()
@@ -286,6 +298,7 @@ Frame::Frame(FrameClient* client, FrameHost* host, FrameOwner* owner)
, m_host(host)
, m_owner(owner)
, m_client(client)
+ , m_frameID(generateFrameID())
, m_isLoading(false)
{
ASSERT(page());

Powered by Google App Engine
This is Rietveld 408576698