Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: Source/core/frame/UseCounter.h

Issue 908453003: Blink changes to record interest rects for http://w3c.github.io/frame-timing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review comments, plus update Render events to get finishTime as well. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/timing/Performance.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 V8StyleSheetList_Item_Method = 762, 696 V8StyleSheetList_Item_Method = 762,
697 StyleSheetListAnonymousNamedGetter = 763, 697 StyleSheetListAnonymousNamedGetter = 763,
698 AutocapitalizeAttribute = 764, 698 AutocapitalizeAttribute = 764,
699 FullscreenSecureOrigin = 765, 699 FullscreenSecureOrigin = 765,
700 FullscreenInsecureOrigin = 766, 700 FullscreenInsecureOrigin = 766,
701 DialogInSandboxedContext = 767, 701 DialogInSandboxedContext = 767,
702 SVGSMILAnimationInImageRegardlessOfCache = 768, 702 SVGSMILAnimationInImageRegardlessOfCache = 768,
703 PushSubscriptionId = 769, 703 PushSubscriptionId = 769,
704 EncryptedMediaSecureOrigin = 770, 704 EncryptedMediaSecureOrigin = 770,
705 EncryptedMediaInsecureOrigin = 771, 705 EncryptedMediaInsecureOrigin = 771,
706 MarkDequeOverflow = 772,
707 StoreBufferOverflow = 773,
708 SlotsBufferOverflow = 774,
709 ObjectObserve = 775,
chrishtr 2015/05/12 03:17:22 What's up with 772-775? A bad rebase?
MikeB 2015/05/12 17:00:09 Ah, I misunderstood the git diff conflict resoluti
710 PerformanceFrameTiming = 776,
706 711
707 // Add new features immediately above this line. Don't change assigned 712 // Add new features immediately above this line. Don't change assigned
708 // numbers of any item, and don't reuse removed slots. 713 // numbers of any item, and don't reuse removed slots.
709 // Also, run update_use_counter_feature_enum.py in chromium/src/tools/me trics/histograms/ 714 // Also, run update_use_counter_feature_enum.py in chromium/src/tools/me trics/histograms/
710 // to update the UMA mapping. 715 // to update the UMA mapping.
711 NumberOfFeatures, // This enum value must be last. 716 NumberOfFeatures, // This enum value must be last.
712 }; 717 };
713 718
714 // "count" sets the bit for this feature to 1. Repeated calls are ignored. 719 // "count" sets the bit for this feature to 1. Repeated calls are ignored.
715 static void count(const Frame*, Feature); 720 static void count(const Frame*, Feature);
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 804
800 bool hasRecordedMeasurement(Feature feature) const { return m_countBits.hasR ecordedMeasurement(feature); } 805 bool hasRecordedMeasurement(Feature feature) const { return m_countBits.hasR ecordedMeasurement(feature); }
801 806
802 CountBits m_countBits; 807 CountBits m_countBits;
803 BitVector m_CSSFeatureBits; 808 BitVector m_CSSFeatureBits;
804 }; 809 };
805 810
806 } // namespace blink 811 } // namespace blink
807 812
808 #endif // UseCounter_h 813 #endif // UseCounter_h
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/timing/Performance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698