Blink changes to record interest rects for http://w3c.github.io/frame-timing/

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2515 matching lines @@
     if (view) {
         TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateLayerTree", TRACE_EVENT_SCOPE_THREAD, "data", InspectorUpdateLayerTreeEvent::data(m_frame.get()));
 
         view->compositor()->updateIfNeededRecursive();
 
         if (view->compositor()->inCompositingMode() && m_frame->isLocalRoot())
             scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
 
         updateCompositedSelectionIfNeeded();
 
+        if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
+            updateFrameTimingRequestsIfNeeded();
+
         scrollContentsIfNeededRecursive();
 
         invalidateTreeIfNeededRecursive();
 
         ASSERT(!view->hasPendingSelection());
     }
 
     ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean);
 }
 
+void FrameView::updateFrameTimingRequestsIfNeeded()
+{
+    GraphicsLayerFrameTimingRequests graphicsLayerTimingRequests;
+    // TODO(mpb) use a 'dirty' bit to not call this every time.
+    collectFrameTimingRequestsRecursive(graphicsLayerTimingRequests);
+
+    for (const auto& iter : graphicsLayerTimingRequests) {
+        const GraphicsLayer* graphicsLayer = iter.key;
+        graphicsLayer->platformLayer()->setFrameTimingRequests(iter.value);
+    }
+}
+
 void FrameView::updateLayoutAndStyleIfNeededRecursive()
 {
     // We have to crawl our entire tree looking for any FrameViews that need
     // layout and make sure they are up to date.
     // Mac actually tests for intersection with the dirty region and tries not to
     // update layout for frames that are outside the dirty region.  Not only does this seem
     // pointless (since those frames will have set a zero timer to layout anyway), but
     // it is also incorrect, since if two frames overlap, the first could be excluded from the dirty
     // region but then become included later by the second frame adding rects to the dirty region
     // when it lays out.
@@ skipping 1439 matching lines @@
 
 LayoutObject* FrameView::viewportLayoutObject()
 {
     if (Document* document = frame().document()) {
         if (Element* element = document->viewportDefiningElement())
             return element->layoutObject();
     }
     return nullptr;
 }
 
+void FrameView::collectFrameTimingRequestsRecursive(GraphicsLayerFrameTimingRequests& graphicsLayerTimingRequests)
+{
+    collectFrameTimingRequests(graphicsLayerTimingRequests);
+
+    for (Frame* child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) {
+        if (!child->isLocalFrame())
+            continue;
+
+        toLocalFrame(child)->view()->collectFrameTimingRequestsRecursive(graphicsLayerTimingRequests);
+    }
+}
+
+void FrameView::collectFrameTimingRequests(GraphicsLayerFrameTimingRequests& graphicsLayerTimingRequests)
+{
+    if (!m_frame->isLocalFrame())
+        return;
+    Frame* frame = m_frame.get();
+    LocalFrame* localFrame = toLocalFrame(frame);
+    LayoutRect rect = localFrame->contentLayoutObject()->viewRect();

[chrishtr, 2015/05/09 00:46:42]

s/rect/viewRect/

[MikeB, 2015/05/11 23:10:51]

Done.

+    const LayoutBoxModelObject* container = localFrame->contentLayoutObject()->containerForPaintInvalidation();
+    const DeprecatedPaintLayer* layer = container->enclosingLayer();

[chrishtr, 2015/05/09 00:46:42]

Some more nits:

Remove the layer local variable, since it's only used once. Rename container to
paintInvalidationContainer for clarity.

+    const GraphicsLayer* graphicsLayer = !layer ? nullptr : layer->graphicsLayerBacking();
+
+    if (!graphicsLayer)
+        return;
+
+    DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentLayoutObject(), container, rect);
+
+    graphicsLayerTimingRequests.add(graphicsLayer, std::vector<std::pair<int64_t, WebRect>>()).storedValue->value.push_back(std::make_pair(m_frame->frameID(), enclosingIntRect(rect)));
+}
+
 } // namespace blink