Blink changes to record interest rects for http://w3c.github.io/frame-timing/

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 46 matching lines @@
 #include "core/frame/Settings.h"
 #include "core/frame/SmartClip.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/canvas/WebGLRenderingContext.h"
 #include "core/html/forms/PopupMenuClient.h"
 #include "core/html/ime/InputMethodContext.h"
 #include "core/inspector/InspectorController.h"
+#include "core/layout/Layer.h"
 #include "core/layout/compositing/LayerCompositor.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/UniqueIdentifier.h"
 #include "core/page/Chrome.h"
 #include "core/page/ContextMenuController.h"
 #include "core/page/ContextMenuProvider.h"
 #include "core/page/DragController.h"
 #include "core/page/DragData.h"
 #include "core/page/DragSession.h"
 #include "core/page/EventHandler.h"
 #include "core/page/FocusController.h"
 #include "core/page/FrameTree.h"
 #include "core/page/InjectedStyleSheets.h"
 #include "core/page/Page.h"
 #include "core/page/PagePopupClient.h"
 #include "core/page/PointerLockController.h"
 #include "core/page/ScopedPageLoadDeferrer.h"
 #include "core/page/TouchDisambiguation.h"
+#include "core/rendering/RenderGeometryMap.h"
 #include "core/rendering/RenderPart.h"
 #include "core/rendering/RenderView.h"
 #include "core/rendering/TextAutosizer.h"
 #include "core/storage/StorageNamespaceController.h"
+#include "core/timing/Performance.h"
 #include "modules/accessibility/AXObject.h"
 #include "modules/accessibility/AXObjectCacheImpl.h"
 #include "modules/credentialmanager/CredentialManagerClient.h"
 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
 #include "modules/encryptedmedia/MediaKeysController.h"
 #include "modules/filesystem/InspectorFileSystemAgent.h"
 #include "modules/indexeddb/InspectorIndexedDBAgent.h"
 #include "modules/webdatabase/InspectorDatabaseAgent.h"
 #include "platform/ContextMenu.h"
 #include "platform/ContextMenuItem.h"
@@ skipping 22 matching lines @@
 #include "public/platform/WebFloatPoint.h"
 #include "public/platform/WebGestureCurve.h"
 #include "public/platform/WebImage.h"
 #include "public/platform/WebLayerTreeView.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/platform/WebVector.h"
 #include "public/web/WebAXObject.h"
 #include "public/web/WebActiveWheelFlingParameters.h"
 #include "public/web/WebAutofillClient.h"
 #include "public/web/WebBeginFrameArgs.h"
+#include "public/web/WebFrame.h"
 #include "public/web/WebFrameClient.h"
 #include "public/web/WebHitTestResult.h"
 #include "public/web/WebInputElement.h"
 #include "public/web/WebMediaPlayerAction.h"
 #include "public/web/WebNode.h"
+#include "public/web/WebPerformance.h"
 #include "public/web/WebPlugin.h"
 #include "public/web/WebPluginAction.h"
 #include "public/web/WebRange.h"
 #include "public/web/WebTextInputInfo.h"
 #include "public/web/WebViewClient.h"
 #include "public/web/WebWindowFeatures.h"
 #include "web/CompositionUnderlineVectorBuilder.h"
 #include "web/ContextFeaturesClientImpl.h"
 #include "web/DatabaseClientImpl.h"
 #include "web/FullscreenController.h"
@@ skipping 1752 matching lines @@
     // FIXME: This should probably be using the local root?
     if (m_page->mainFrame()->isLocalFrame())
         PageWidgetDelegate::animate(*m_page, validFrameTime.lastFrameTimeMonotonic, *m_page->deprecatedLocalMainFrame());
 
     if (m_continuousPaintingEnabled) {
         ContinuousPainter::setNeedsDisplayRecursive(m_rootGraphicsLayer, m_pageOverlays.get());
         m_client->scheduleAnimation();
     }
 }
 
+static void findFrameTimingRequestRects(Page* page)

[enne (OOO), 2015/02/10 00:17:49]

Sorry for always bikeshedding, but find in a function name makes me think it
returns something.  Maybe "update" or "push"?

[MikeB, 2015/03/18 21:18:34]

Done.

+{
+    typedef WTF::HashMap<const GraphicsLayer*,

[enne (OOO), 2015/02/10 00:17:49]

It's really too bad that Blink hasn't moved into the Chromium repo, because this
seems like a lot of data structure contortion to fit a "set all the rects" API,
when a "add one more request" would be more natural but have more overhead to go
through the bindings.  (That said, if there aren't many requests, maybe that'd
be cleaner anyway.)

[MikeB, 2015/03/18 21:18:34]

I'm happy to take a stab at it, but not 100% clear on what you mean by a 
"add one more request" API. If you give me a little more info on what you have
in mind, I can see if it's feasible. Thanks!

+        std::vector<std::pair<int64_t, WebRect>>>
+        GraphicsLayerFrameTimingRects;

[enne (OOO), 2015/02/10 00:17:49]

Rects => Requests?

[MikeB, 2015/03/18 21:18:34]

Done.

+
+    GraphicsLayerFrameTimingRects glRects;
+
+    for (Frame* frame = page ? page->mainFrame() : 0; frame;
+        frame = frame->tree().traverseNext()) {
+
+        if (!frame->isLocalFrame())

[enne (OOO), 2015/02/10 00:17:49]

Can you leave a comment why this is? How do requests on non-local frames get
handled?

[MikeB, 2015/03/18 21:18:34]

If I don't have a local frame, then I don't have a GraphicsLayer, so calling the
APi doesn't make much sense. Or am I mis-interpreting what isLocalFrame means?
I'm getting GraphicsLayer from either Document or HTMLFrameOwnerElement which
both come from LocalFrame.

+            continue;
+
+        LocalFrame* localframe = toLocalFrame(frame);
+        Document* document = localframe->document();
+        HTMLFrameOwnerElement* ownerElement = document->ownerElement();
+
+        const GraphicsLayer* graphicsLayer;
+
+        // Find frame's rect in graphics layer space
+        LayoutRect rect =
+            localframe->contentRenderer()->rectForPaintInvalidation();
+
+        if (document->renderView()->enclosingLayer()->compositingState()
+            == PaintsIntoOwnBacking || !ownerElement) {
+            graphicsLayer = document->renderView()->enclosingLayer()
+                ->enclosingLayerForPaintInvalidationCrossingFrameBoundaries()
+                ->graphicsLayerBacking();
+        } else {
+            if (!ownerElement->renderer())
+                continue;
+            graphicsLayer = ownerElement->renderer()->enclosingLayer()
+                ->enclosingLayerForPaintInvalidationCrossingFrameBoundaries()
+                ->graphicsLayerBacking();
+
+            Layer::mapRectToPaintInvalidationBacking(
+                ownerElement->renderer(),
+                ownerElement->renderer()->containerForPaintInvalidation(),
+                rect);
+        }
+
+        GraphicsLayerFrameTimingRects::iterator glIter = glRects.find(graphicsLayer);
+        std::vector<std::pair<int64_t, WebRect>> *glVector;
+        if (glIter == glRects.end()) {
+            glVector = &glRects.add(graphicsLayer,
+                std::vector<std::pair<int64_t, WebRect>>()).storedValue->value;
+        } else {
+            glVector = &glIter->value;
+        }
+        glVector->push_back(std::make_pair(frame->frameID(), enclosingIntRect(rect)));
+    }
+
+    for (GraphicsLayerFrameTimingRects::const_iterator iter = glRects.begin(); iter != glRects.end(); ++iter) {
+        const GraphicsLayer* graphicsLayer = iter->key;
+        graphicsLayer->platformLayer()->setFrameTimingRequests(iter->value);
+    }
+}
+
 void WebViewImpl::layout()
 {
     TRACE_EVENT0("blink", "WebViewImpl::layout");
     if (!localFrameRootTemporary())
         return;
 
     PageWidgetDelegate::layout(*m_page, *localFrameRootTemporary()->frame());
     updateLayerTreeBackgroundColor();
 
     for (size_t i = 0; i < m_linkHighlights.size(); ++i)
         m_linkHighlights[i]->updateGeometry();
+
+    findFrameTimingRequestRects(m_page.get());
 }
 
 void WebViewImpl::paint(WebCanvas* canvas, const WebRect& rect)
 {
     // This should only be used when compositing is not being used for this
     // WebView, and it is painting into the recording of its parent.
     ASSERT(!isAcceleratedCompositingActive());
 
     double paintStart = currentTime();
     PageWidgetDelegate::paint(*m_page, pageOverlays(), canvas, rect, isTransparent() ? PageWidgetDelegate::Translucent : PageWidgetDelegate::Opaque, *m_page->deprecatedLocalMainFrame());
@@ skipping 2525 matching lines @@
         WebSize scrollOffset = mainFrame()->scrollOffset();
         scrollOffset.width += scrollDelta.width;
         scrollOffset.height += scrollDelta.height;
 
         WebPoint scrollPoint(scrollOffset.width, scrollOffset.height);
         setPageScaleFactor(pageScaleFactor() * pageScaleDelta, scrollPoint);
         m_doubleTapZoomPending = false;
     }
 }
 
+void WebViewImpl::recordFrameTimingEvent(frameTimingEventType eventType, int64_t FrameId, const WebVector<std::pair<int, double>>& events)
+{
+    if (!mainFrameImpl() || !mainFrameImpl()->frameView())
+        return;
+
+    Frame* frame = m_page ? m_page->mainFrame() : 0;
+
+    while (frame && frame->frameID() != FrameId) {
+        frame = frame->tree().traverseNext();
+    }
+
+    if (!frame || !frame->domWindow() || !frame->domWindow()->performance()
+        || !frame->domWindow()->document())
+        return; // ASSERT? Other way to report error?
+
+    ASSERT(frame->isLocalFrame());
+
+    Performance* performance = frame->domWindow()->performance();
+    for (size_t i = 0; i < events.size(); ++i) {
+        if (eventType == CompositeEvent)
+            performance->addCompositeTiming(frame->domWindow()->document(), events[i].first, events[i].second);
+        else if (eventType == RenderEvent)
+            performance->addRenderTiming(frame->domWindow()->document(), events[i].first, events[i].second);
+    }
+}
+
 void WebViewImpl::updateLayerTreeViewport()
 {
     if (!page() || !m_layerTreeView)
         return;
 
     m_layerTreeView->setPageScaleFactorAndLimits(pageScaleFactor(), minimumPageScaleFactor(), maximumPageScaleFactor());
 }
 
 void WebViewImpl::updateLayerTreeBackgroundColor()
 {
@@ skipping 140 matching lines @@
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 void WebViewImpl::forceNextWebGLContextCreationToFail()
 {
     WebGLRenderingContext::forceNextWebGLContextCreationToFail();
 }
 
 } // namespace blink