Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: test/cctest/test-reloc-info.cc

Issue 908443002: Remove redundant source position information in RelocInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/assembler-x87.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 SmartArrayPointer<byte> buffer(new byte[buffer_size]); 48 SmartArrayPointer<byte> buffer(new byte[buffer_size]);
49 49
50 byte* pc = buffer.get(); 50 byte* pc = buffer.get();
51 byte* buffer_end = buffer.get() + buffer_size; 51 byte* buffer_end = buffer.get() + buffer_size;
52 52
53 RelocInfoWriter writer(buffer_end, pc); 53 RelocInfoWriter writer(buffer_end, pc);
54 byte* relocation_info_end = buffer_end - relocation_info_size; 54 byte* relocation_info_end = buffer_end - relocation_info_size;
55 for (int i = 0, pos = 0; i < 100; i++, pc += i, pos += i) { 55 for (int i = 0, pos = 0; i < 100; i++, pc += i, pos += i) {
56 RelocInfo::Mode mode = (i % 2 == 0) ? 56 RelocInfo::Mode mode = (i % 2 == 0) ?
57 RelocInfo::STATEMENT_POSITION : RelocInfo::POSITION; 57 RelocInfo::STATEMENT_POSITION : RelocInfo::POSITION;
58 if (mode == RelocInfo::STATEMENT_POSITION) {
59 printf("TEST WRITING STATEMENT %p %d\n", pc, pos);
60 } else {
61 printf("TEST WRITING POSITION %p %d\n", pc, pos);
62 }
58 WriteRinfo(&writer, pc, mode, pos); 63 WriteRinfo(&writer, pc, mode, pos);
59 CHECK(writer.pos() - RelocInfoWriter::kMaxSize >= relocation_info_end); 64 CHECK(writer.pos() - RelocInfoWriter::kMaxSize >= relocation_info_end);
60 } 65 }
61 66
67 writer.Finish();
62 relocation_info_size = static_cast<int>(buffer_end - writer.pos()); 68 relocation_info_size = static_cast<int>(buffer_end - writer.pos());
63 CodeDesc desc = { buffer.get(), buffer_size, code_size, 69 CodeDesc desc = { buffer.get(), buffer_size, code_size,
64 relocation_info_size, NULL }; 70 relocation_info_size, NULL };
65 71
66 // Read only (non-statement) positions. 72 // Read only (non-statement) positions.
67 { 73 {
68 RelocIterator it(desc, RelocInfo::ModeMask(RelocInfo::POSITION)); 74 RelocIterator it(desc, RelocInfo::ModeMask(RelocInfo::POSITION));
69 pc = buffer.get(); 75 pc = buffer.get();
70 for (int i = 0, pos = 0; i < 100; i++, pc += i, pos += i) { 76 for (int i = 0, pos = 0; i < 100; i++, pc += i, pos += i) {
77 printf("TESTING 1: %d\n", i);
71 RelocInfo::Mode mode = (i % 2 == 0) ? 78 RelocInfo::Mode mode = (i % 2 == 0) ?
72 RelocInfo::STATEMENT_POSITION : RelocInfo::POSITION; 79 RelocInfo::STATEMENT_POSITION : RelocInfo::POSITION;
73 if (mode == RelocInfo::POSITION) { 80 if (mode == RelocInfo::POSITION) {
74 CHECK_EQ(pc, it.rinfo()->pc()); 81 CHECK_EQ(pc, it.rinfo()->pc());
75 CHECK_EQ(mode, it.rinfo()->rmode()); 82 CHECK_EQ(mode, it.rinfo()->rmode());
76 CHECK_EQ(pos, static_cast<int>(it.rinfo()->data())); 83 CHECK_EQ(pos, static_cast<int>(it.rinfo()->data()));
77 it.next(); 84 it.next();
78 } 85 }
79 } 86 }
80 CHECK(it.done()); 87 CHECK(it.done());
(...skipping 26 matching lines...) Expand all
107 CHECK_EQ(pc, it.rinfo()->pc()); 114 CHECK_EQ(pc, it.rinfo()->pc());
108 CHECK_EQ(mode, it.rinfo()->rmode()); 115 CHECK_EQ(mode, it.rinfo()->rmode());
109 CHECK_EQ(pos, static_cast<int>(it.rinfo()->data())); 116 CHECK_EQ(pos, static_cast<int>(it.rinfo()->data()));
110 it.next(); 117 it.next();
111 } 118 }
112 CHECK(it.done()); 119 CHECK(it.done());
113 } 120 }
114 } 121 }
115 122
116 } } // namespace v8::internal 123 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x87/assembler-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698