Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 908443002: Remove redundant source position information in RelocInfo (Closed)

Created:
5 years, 10 months ago by danno
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove redundant source position information in RelocInfo Previously, emitting two more more unique source positions at the same pc would generate two or more RelocInfo entries. Now, only the last emitted source position for any pc is added to the RelocInfo. Committed: https://crrev.com/e87c0bac3540b8ba24b02dfcc65af485f4020157 Cr-Commit-Position: refs/heads/master@{#26608}

Patch Set 1 #

Patch Set 2 : Fix offsets #

Patch Set 3 : Lates #

Patch Set 4 : Fixes #

Patch Set 5 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -18 lines) Patch
M src/arm/assembler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.h View 1 2 3 4 3 chunks +28 lines, -8 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 4 chunks +43 lines, -10 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-reloc-info.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danno
PTAL
5 years, 10 months ago (2015-02-06 16:36:14 UTC) #2
Yang
On 2015/02/06 16:36:14, danno wrote: > PTAL lgtm.
5 years, 10 months ago (2015-02-11 15:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908443002/80001
5 years, 10 months ago (2015-02-12 11:53:39 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-12 12:15:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 12:15:41 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e87c0bac3540b8ba24b02dfcc65af485f4020157
Cr-Commit-Position: refs/heads/master@{#26608}

Powered by Google App Engine
This is Rietveld 408576698