Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: ui/app_list/app_list_unittests.isolate

Issue 908313004: Use Xvfb in isolated testing only if use_x11 is set (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments from maruel@ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_unittests.isolate ('k') | ui/base/ui_base_unittests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/app_list_unittests.isolate
diff --git a/ui/app_list/app_list_unittests.isolate b/ui/app_list/app_list_unittests.isolate
index 5ef000697799ab33602a4b15074c9a479917bf0f..e3edaa3ca6ae5d15d67524964e27321311b4abde 100644
--- a/ui/app_list/app_list_unittests.isolate
+++ b/ui/app_list/app_list_unittests.isolate
@@ -3,16 +3,20 @@
# found in the LICENSE file.
{
'conditions': [
- ['OS=="linux" or OS=="mac" or OS=="win"', {
+ ['use_x11==0', {
'variables': {
- 'files': [
+ 'command': [
'../../testing/test_env.py',
'<(PRODUCT_DIR)/app_list_unittests<(EXECUTABLE_SUFFIX)',
- '<(PRODUCT_DIR)/ui_test.pak',
+ '--brave-new-test-launcher',
+ '--test-launcher-bot-mode',
+ '--asan=<(asan)',
+ '--msan=<(msan)',
+ '--tsan=<(tsan)',
],
},
}],
- ['OS=="linux"', {
+ ['use_x11==1', {
'variables': {
'command': [
'../../testing/xvfb.py',
@@ -26,41 +30,37 @@
],
'files': [
'../../testing/xvfb.py',
- '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
- ['OS=="linux" and use_ozone==0', {
+ ['OS=="linux" or OS=="mac" or OS=="win"', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '../../testing/test_env.py',
+ '<(PRODUCT_DIR)/app_list_unittests<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/ui_test.pak',
],
},
}],
- ['OS=="mac"', {
+ ['OS=="linux"', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/osmesa.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
],
},
}],
- ['OS=="win"', {
+ ['OS=="mac"', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/osmesa.dll',
+ '<(PRODUCT_DIR)/osmesa.so',
],
},
}],
- ['OS=="mac" or OS=="win"', {
+ ['OS=="win"', {
'variables': {
- 'command': [
- '../../testing/test_env.py',
- '<(PRODUCT_DIR)/app_list_unittests<(EXECUTABLE_SUFFIX)',
- '--brave-new-test-launcher',
- '--test-launcher-bot-mode',
- '--asan=<(asan)',
- '--msan=<(msan)',
- '--tsan=<(tsan)',
+ 'files': [
+ '<(PRODUCT_DIR)/osmesa.dll',
],
},
}],
« no previous file with comments | « content/content_unittests.isolate ('k') | ui/base/ui_base_unittests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698