Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: ash/ash_unittests.isolate

Issue 908313004: Use Xvfb in isolated testing only if use_x11 is set (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments from maruel@ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_unittests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/ash_unittests.isolate
diff --git a/ash/ash_unittests.isolate b/ash/ash_unittests.isolate
index 918a8e0252930e5616552d84d938803334d1dfc8..319dfc7bb2ad2a630fbdc2c106ceba41b07a3788 100644
--- a/ash/ash_unittests.isolate
+++ b/ash/ash_unittests.isolate
@@ -3,19 +3,16 @@
# found in the LICENSE file.
{
'conditions': [
- ['OS=="win" or chromeos==1', {
+ ['use_x11==0', {
'variables': {
- 'files': [
+ 'command': [
'../testing/test_env.py',
'<(PRODUCT_DIR)/ash_unittests<(EXECUTABLE_SUFFIX)',
- '<(PRODUCT_DIR)/chrome_100_percent.pak',
- '<(PRODUCT_DIR)/chrome_200_percent.pak',
- '<(PRODUCT_DIR)/locales/en-US.pak',
- '<(PRODUCT_DIR)/keyboard_resources.pak',
+ '--test-launcher-bot-mode',
],
},
}],
- ['OS=="linux"', {
+ ['use_x11==1', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -25,25 +22,32 @@
],
'files': [
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
- ['OS=="linux" and use_ozone==0', {
+ ['OS=="win" or chromeos==1', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '../testing/test_env.py',
+ '<(PRODUCT_DIR)/ash_unittests<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/chrome_100_percent.pak',
+ '<(PRODUCT_DIR)/chrome_200_percent.pak',
+ '<(PRODUCT_DIR)/locales/en-US.pak',
+ '<(PRODUCT_DIR)/keyboard_resources.pak',
],
},
}],
- ['OS=="win"', {
+ ['OS=="linux"', {
'variables': {
- 'command': [
- '../testing/test_env.py',
- '<(PRODUCT_DIR)/ash_unittests.exe',
- '--test-launcher-bot-mode',
+ 'files': [
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
],
+ },
+ }],
+ ['OS=="win"', {
+ 'variables': {
'files': [
'<(PRODUCT_DIR)/ffmpegsumo.dll',
'<(PRODUCT_DIR)/osmesa.dll',
« no previous file with comments | « no previous file | base/base_unittests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698