Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: ui/touch_selection/ui_touch_selection_unittests.isolate

Issue 908313004: Use Xvfb in isolated testing only if use_x11 is set (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/ui_touch_selection_unittests.isolate
diff --git a/ui/touch_selection/ui_touch_selection_unittests.isolate b/ui/touch_selection/ui_touch_selection_unittests.isolate
index 4e8079af87c3d40fcd05168d1956348732afa6fd..e32ab83ea810fbfc981eb6d3cd4b62e8956daec4 100644
--- a/ui/touch_selection/ui_touch_selection_unittests.isolate
+++ b/ui/touch_selection/ui_touch_selection_unittests.isolate
@@ -11,11 +11,10 @@
],
},
}],
- ['OS=="linux"', {
+ ['use_x11==0', {
'variables': {
'command': [
- '../../testing/xvfb.py',
- '<(PRODUCT_DIR)',
+ '../../testing/test_env.py',
'<(PRODUCT_DIR)/ui_touch_selection_unittests<(EXECUTABLE_SUFFIX)',
'--brave-new-test-launcher',
'--test-launcher-bot-mode',
@@ -23,23 +22,13 @@
'--msan=<(msan)',
'--tsan=<(tsan)',
],
- 'files': [
- '../../testing/xvfb.py',
- '<(PRODUCT_DIR)/libosmesa.so',
- ],
- },
- }],
- ['OS=="linux" and use_ozone==0', {
- 'variables': {
- 'files': [
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
- ],
},
}],
- ['OS=="mac" or OS=="win"', {
+ ['use_x11==1', {
'variables': {
'command': [
- '../../testing/test_env.py',
+ '../../testing/xvfb.py',
+ '<(PRODUCT_DIR)',
'<(PRODUCT_DIR)/ui_touch_selection_unittests<(EXECUTABLE_SUFFIX)',
'--brave-new-test-launcher',
'--test-launcher-bot-mode',
@@ -47,6 +36,17 @@
'--msan=<(msan)',
'--tsan=<(tsan)',
],
+ 'files': [
+ '../../testing/xvfb.py',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ ],
+ },
+ }],
+ ['OS=="linux"', {
+ 'variables': {
+ 'files': [
+ '<(PRODUCT_DIR)/libosmesa.so',
+ ],
},
}],
['OS=="mac" and asan==1 and fastbuild==0', {
« chrome/browser_tests.isolate ('K') | « ui/message_center/message_center_unittests.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698