Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: base/base_unittests.isolate

Issue 908313004: Use Xvfb in isolated testing only if use_x11 is set (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments from maruel@ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/ash_unittests.isolate ('k') | build/android/pylib/utils/isolator.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'conditions': [ 5 'conditions': [
6 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', { 6 ['use_x11==0', {
7 'variables': { 7 'variables': {
8 'files': [ 8 'command': [
9 'test/data/', 9 '../testing/test_env.py',
10 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
11 '--brave-new-test-launcher',
12 '--test-launcher-bot-mode',
13 '--asan=<(asan)',
14 '--msan=<(msan)',
15 '--tsan=<(tsan)',
10 ], 16 ],
11 }, 17 },
12 }], 18 }],
13 ['OS=="linux"', { 19 ['use_x11==1', {
14 'variables': { 20 'variables': {
15 'command': [ 21 'command': [
16 '../testing/xvfb.py', 22 '../testing/xvfb.py',
17 '<(PRODUCT_DIR)', 23 '<(PRODUCT_DIR)',
18 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)', 24 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
19 '--brave-new-test-launcher', 25 '--brave-new-test-launcher',
20 '--test-launcher-bot-mode', 26 '--test-launcher-bot-mode',
21 '--asan=<(asan)', 27 '--asan=<(asan)',
22 '--msan=<(msan)', 28 '--msan=<(msan)',
23 '--tsan=<(tsan)', 29 '--tsan=<(tsan)',
24 ], 30 ],
25 'files': [ 31 'files': [
26 '../testing/xvfb.py', 32 '../testing/xvfb.py',
27 ],
28 },
29 }],
30 ['OS=="linux" and use_ozone==0', {
31 'variables': {
32 'files': [
33 '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)', 33 '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
34 ], 34 ],
35 }, 35 },
36 }], 36 }],
37 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
38 'variables': {
39 'files': [
40 'test/data/',
41 ],
42 },
43 }],
37 ['OS=="linux" or OS=="mac" or OS=="win"', { 44 ['OS=="linux" or OS=="mac" or OS=="win"', {
38 'variables': { 45 'variables': {
39 'files': [ 46 'files': [
40 '../testing/test_env.py', 47 '../testing/test_env.py',
41 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)', 48 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
42 ], 49 ],
43 'read_only': 1, 50 'read_only': 1,
44 }, 51 },
45 }], 52 }],
46 ['OS=="mac" or OS=="win"', {
47 'variables': {
48 'command': [
49 '../testing/test_env.py',
50 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
51 '--brave-new-test-launcher',
52 '--test-launcher-bot-mode',
53 '--asan=<(asan)',
54 '--msan=<(msan)',
55 '--tsan=<(tsan)',
56 ],
57 },
58 }],
59 ['OS=="mac" and asan==1 and fastbuild==0', { 53 ['OS=="mac" and asan==1 and fastbuild==0', {
60 'variables': { 54 'variables': {
61 'files': [ 55 'files': [
62 '<(PRODUCT_DIR)/base_unittests.dSYM/', 56 '<(PRODUCT_DIR)/base_unittests.dSYM/',
63 ], 57 ],
64 }, 58 },
65 }], 59 }],
66 ['OS=="win" and (fastbuild==0 or fastbuild==1)', { 60 ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
67 'variables': { 61 'variables': {
68 'files': [ 62 'files': [
69 '<(PRODUCT_DIR)/base_unittests.exe.pdb', 63 '<(PRODUCT_DIR)/base_unittests.exe.pdb',
70 ], 64 ],
71 }, 65 },
72 }], 66 }],
73 ], 67 ],
74 'includes': [ 68 'includes': [
75 'base.isolate', 69 'base.isolate',
76 ], 70 ],
77 } 71 }
OLDNEW
« no previous file with comments | « ash/ash_unittests.isolate ('k') | build/android/pylib/utils/isolator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698