Source/core/editing/TextCheckingHelper.cpp - Issue 908303002: Fix the range returned by findFirstMisspelling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextCheckingHelper.cpp

Issue 908303002: Fix the range returned by findFirstMisspelling Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/TextCheckingHelper.cpp

diff --git a/Source/core/editing/TextCheckingHelper.cpp b/Source/core/editing/TextCheckingHelper.cpp

index 3362592bab1e60f86593d7b4b5a29b4835b76adc..558cedaa5d15a6b3deac47f4e17564618323ac52 100644

--- a/Source/core/editing/TextCheckingHelper.cpp

+++ b/Source/core/editing/TextCheckingHelper.cpp

@@ -269,7 +269,7 @@ String TextCheckingHelper::findFirstMisspelling(int& firstMisspellingOffset, boo

if (!firstMisspelling) {

firstMisspellingOffset = currentChunkOffset + misspellingLocation;

firstMisspelling = it.substring(misspellingLocation, misspellingLength);

- firstMisspellingRange = Range::create(misspellingStart.containerNode()->document(), m_start, m_end);

+ firstMisspellingRange = Range::create(misspellingStart.containerNode()->document(), misspellingStart, misspellingEnd);

yosin_UTC9 2015/05/21 02:28:49 It seems current code is correct, since |misspelli

}

// Store marker for misspelled word.

« no previous file with comments | « no previous file | no next file » | no next file with comments »