Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/v8_stats.py

Issue 908223003: Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/v8_stats.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/v8_stats.py b/tools/telemetry/telemetry/web_perf/metrics/v8_stats.py
new file mode 100644
index 0000000000000000000000000000000000000000..49a11a5e819a4e100100898cb01c9172806b5196
--- /dev/null
+++ b/tools/telemetry/telemetry/web_perf/metrics/v8_stats.py
@@ -0,0 +1,64 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+class EventStats(object):
+ def __init__(self, src_event_name, result_name, result_description):
+ self.src_event_name = src_event_name
+ self.result_name = result_name
+ self.result_description = result_description
+ self.thread_duration = 0.0
+ self.thread_duration_inside_idle = 0.0
+
+ @property
+ def thread_duration_outside_idle(self):
+ return self.thread_duration - self.thread_duration_inside_idle
+
+
+def _FindEventStats(event_stats_list, event_name):
+ for event_stats in event_stats_list:
+ if event_stats.src_event_name == event_name:
+ return event_stats
+ return None
+
+
+def _IsDescendentOfIdleNotification(event):
+ parent = event.parent_slice
+ while parent:
+ if parent.name == 'V8.GCIdleNotification':
+ return True
+ parent = parent.parent_slice
+ return False
+
+class V8Stats(object):
+ def __init__(self, renderer_thread, interaction_records):
+ self.all_event_stats = [
+ EventStats('V8.GCIncrementalMarking',
+ 'incremental_marking',
+ 'total thread duration spent in incremental marking steps'),
+ EventStats('V8.GCScavenger',
+ 'scavenger',
+ 'total thread duration spent in scavenges'),
+ EventStats('V8.GCCompactor',
+ 'mark_compactor',
+ 'total thread duration spent in mark-sweep-compactor')]
+
+ # Find all GC events contained in an interaction record
+ for event in renderer_thread.IterAllSlices():
+ event_stats = _FindEventStats(self.all_event_stats, event.name)
+ if not event_stats:
+ continue
+ for r in interaction_records:
+ if not r.GetBounds().ContainsInterval(event.start, event.end):
+ continue
+ event_stats.thread_duration += event.thread_duration
+ if _IsDescendentOfIdleNotification(event):
+ event_stats.thread_duration_inside_idle += event.thread_duration
+
+ @property
+ def total_gc_thread_duration(self):
+ return sum(x.thread_duration for x in self.all_event_stats)
+
+ @property
+ def total_gc_thread_duration_outside_idle(self):
+ return sum(x.thread_duration_outside_idle for x in self.all_event_stats)

Powered by Google App Engine
This is Rietveld 408576698