Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 908073002: Revert of Support listening for available screens for multiple presentation urls in the same frame (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support listening for available screens for multiple presentation urls in the same frame (patchset #2 id:20001 of https://codereview.chromium.org/906113002/) Reason for revert: Bot failure: http://build.chromium.org/p/chromium.webkit/builders/GPU%20Linux%20Builder%20%28dbg%29/builds/28448 Original issue's description: > Support listening for available screens for multiple > Presentation URLs on a per frame basis. > > This is done by associating PresentationServiceImpl > with the RenderFrameHost. When Presentation API > requests are passed to PresentationServiceImpl, it > will delegate to the embedder's Media Router along > with the frame id via the PresentationServiceDelegate > interface. > > Each PresentationServiceImpl also maintains a hash > map of Presentation URLs currently registered to > "context" objects. These objects wait for both result > and renderer (i.e. callback) to both be ready before > sending the result back to renderer / > PresentationDispatcher. > > Furthermore, PresentationServiceImpl listens for > changes to the RenderFrameHost. If an out of page > navigation occurred or if RenderFrameHost is > being destroyed, all current Presentation URLs > are unregistered. > > Also added unit tests for PresentationSerivceImpl. > > BUG=412331 > > Committed: https://crrev.com/ec17a20355dbc3b05e2133c0112c332167b63ce7 > Cr-Commit-Position: refs/heads/master@{#315442} TBR=avi@chromium.org,avayvod@chromium.org,imcheng@chromium.org,imcheng@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=412331 Committed: https://crrev.com/9e4a7ad0e922d3f6a9d648e2ac1696a5136ea87f Cr-Commit-Position: refs/heads/master@{#315449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -596 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 1 chunk +11 lines, -119 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 chunk +4 lines, -175 lines 0 comments Download
D content/browser/presentation/presentation_service_impl_unittest.cc View 1 chunk +0 lines, -299 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jiayl
Created Revert of Support listening for available screens for multiple presentation urls in the same ...
5 years, 10 months ago (2015-02-10 00:19:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908073002/1
5 years, 10 months ago (2015-02-10 00:19:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 00:20:40 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 00:21:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e4a7ad0e922d3f6a9d648e2ac1696a5136ea87f
Cr-Commit-Position: refs/heads/master@{#315449}

Powered by Google App Engine
This is Rietveld 408576698