Prevent inline CRX installs in popup windows.

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 #include "chrome/browser/extensions/webstore_inline_installer_factory.h"
 #include "chrome/browser/extensions/webstore_installer_test.h"
 #include "chrome/browser/extensions/webstore_standalone_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"

[Devlin, 2015/02/12 17:18:21]

needed?

[meacer, 2015/02/12 21:12:05]

Not anymore :)

 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "url/gurl.h"
 
 using content::WebContents;
 
 namespace extensions {
 
 namespace {
 
@@ skipping 92 matching lines @@
       WebContents* contents,
       const std::string& webstore_item_id,
       const GURL& requestor_url,
       const WebstoreStandaloneInstaller::Callback& callback) override {
     return new WebstoreInlineInstallerForTest(
         contents, webstore_item_id, requestor_url, callback);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
-    CloseTabBeforeInstallConfirmation) {
+                       CloseTabBeforeInstallConfirmation) {
   GURL install_url = GenerateTestServerUrl(kAppDomain, "install.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   TabHelper* tab_helper = TabHelper::FromWebContents(web_contents);
   tab_helper->SetWebstoreInlineInstallerFactoryForTests(
       new WebstoreInlineInstallerForTestFactory());
   RunTestAsync("runTest");
   while (!ProgrammableInstallPrompt::Ready())
     base::RunLoop().RunUntilIdle();
   web_contents->Close();
   ProgrammableInstallPrompt::Accept();
 }
 
+IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
+                       ShouldBlockInlineInstallFromPopupWindow) {
+  GURL install_url =
+      GenerateTestServerUrl(kAppDomain, "install_from_popup.html");
+  content::OpenURLParams params(install_url, content::Referrer(), NEW_POPUP,
+                                ui::PAGE_TRANSITION_TYPED, false);
+  params.user_gesture = true;
+  WebContents* web_contents = browser()->OpenURL(params);
+  WaitForLoadStop(web_contents);
+  RunTest(web_contents, "runTest");
+}
+
 // Ensure that inline-installing a disabled extension simply re-enables it.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        ReinstallDisabledExtension) {
   // Install an extension via inline install, and confirm it is successful.
   ExtensionInstallPrompt::g_auto_confirm_for_tests =
       ExtensionInstallPrompt::ACCEPT;
   ui_test_utils::NavigateToURL(
       browser(), GenerateTestServerUrl(kAppDomain, "install.html"));
   RunTest("runTest");
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
@@ skipping 64 matching lines @@
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerListenerTest,
                        DownloadProgressListenerTest) {
   RunTest("download_progress_listener.html");
 }
 
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerListenerTest, BothListenersTest) {
   RunTest("both_listeners.html");
 }
 
 }  // namespace extensions