ui/base/BUILD.gn - Issue 908033003: Remove dependency from ui/base to cc on non-Android platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/BUILD.gn

Issue 908033003: Remove dependency from ui/base to cc on non-Android platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/BUILD.gn

diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn

index 45298447636bfac91097e1d174efcf929899f2d1..e10e97e9d172f258f9b59df878652993022a2446 100644

--- a/ui/base/BUILD.gn

+++ b/ui/base/BUILD.gn

@@ -306,7 +306,6 @@ component("base") {

"//base/third_party/dynamic_annotations",

"//base:base_static",

"//base:i18n",

- "//cc",

"//net",

"//third_party/icu",

"//ui/events",

@@ -528,7 +527,10 @@ component("base") {

"ui_base_types.cc",

]

- deps += [ ":ui_base_jni_headers" ]

+ deps += [

+ "//cc",

Nico 2015/02/10 02:48:32 It's a bit wild that this dep is required on andro

+ ":ui_base_jni_headers",

+ ]

libs += [ "jnigraphics" ]

}

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | ui/base/DEPS » ('j') | no next file with comments »