Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 908003002: Remove "nacl_defines" from the GN build. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
Reviewers:
Mark Seaborn, Nico
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "nacl_defines" from the GN build. The following NaCl-related defines are now provided by native_client/src/include/build_config.h instead of the build system: NACL_WINDOWS NACL_LINUX NACL_OSX NACL_ANDROID NACL_BUILD_ARCH NACL_BUILD_SUBARCH This change removes these definitions from gn(i) files, as they no longer need to be provided by the build system. BUG=440012 Committed: https://crrev.com/2b59c805e1e097e10c36650573fa5c47cd47dc03 Cr-Commit-Position: refs/heads/master@{#315408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D components/nacl/nacl_defines.gni View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
teravest
5 years, 10 months ago (2015-02-09 22:05:41 UTC) #2
Mark Seaborn
LGTM
5 years, 10 months ago (2015-02-09 22:14:14 UTC) #3
teravest
+thakis for chrome/browser/
5 years, 10 months ago (2015-02-09 22:17:02 UTC) #5
Nico
lgtm
5 years, 10 months ago (2015-02-09 22:17:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908003002/1
5 years, 10 months ago (2015-02-09 22:22:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 22:26:12 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:26:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b59c805e1e097e10c36650573fa5c47cd47dc03
Cr-Commit-Position: refs/heads/master@{#315408}

Powered by Google App Engine
This is Rietveld 408576698