Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 907973004: Reland #3: Ensure WebView notifies desktop automation on creation, (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #3: Ensure WebView notifies desktop automation on creation, destruction, and change Original issue: https://codereview.chromium.org/880063002 Previous reland attempt: https://codereview.chromium.org/895623003/ previous reland attempt 2: https://codereview.chromium.org/890013006/ - able to reproduce the flakes locally by running multiple copies of the same test in parallel. - tracked the issues down to the following points/solutions: 1. in automation_node.js, we now fire a loadComplete event if we detect a loaded root within enableFrame's callback. Previously, there could be a situation where a tree was already finished loading so it never actually fires that load complete. 2. in automation_node.js, we now store the callback that fires childrenChanged and the loadComplete above before requesting the browser initiate tree only accessibility which sends down the data. 3. in chromevox_next_e2e_test_base.js, we now check that the url contains 'test' to avoid processing loadCompletes from other rootWebAreas (e.g. about:blank). TBR=dmazzoni@chromium.org Committed: https://crrev.com/4da650e88c859e6d1c2d82993cd6ed3376e77f80 Cr-Commit-Position: refs/heads/master@{#315785}

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -123 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 5 chunks +32 lines, -51 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 4 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 2 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 1 chunk +18 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/base/extension_js_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 7 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng
5 years, 10 months ago (2015-02-10 00:03:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907973004/20001
5 years, 10 months ago (2015-02-11 17:12:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 17:18:55 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4da650e88c859e6d1c2d82993cd6ed3376e77f80 Cr-Commit-Position: refs/heads/master@{#315785}
5 years, 10 months ago (2015-02-11 17:19:51 UTC) #6
David Tseng
5 years, 10 months ago (2015-02-11 18:05:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/891633004/ by dtseng@chromium.org.

The reason for reverting is: Still flakes....

Powered by Google App Engine
This is Rietveld 408576698