Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 907913002: Temporarily disable ppapi mojo test. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable ppapi mojo test. An IRT layer is being added to Mojo NaCl support. The change to the Mojo repository for this will temporarily break ppapi mojo support until a corresponding chrome change is landed to make the Mojo IRT interface available in Chrome. BUG=454466 R=dmichael@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/64c23723b3f3b67d0aab3e605645ae434f6affad

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reference bug in comment. #

Patch Set 3 : Disable test in ppapi_browsertest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
teravest
5 years, 10 months ago (2015-02-09 17:03:02 UTC) #2
dmichael (off chromium)
lgtm https://codereview.chromium.org/907913002/diff/1/ppapi/tests/mojo/test_mojo.cc File ppapi/tests/mojo/test_mojo.cc (right): https://codereview.chromium.org/907913002/diff/1/ppapi/tests/mojo/test_mojo.cc#newcode18 ppapi/tests/mojo/test_mojo.cc:18: // Chrome. nit: it would be good to ...
5 years, 10 months ago (2015-02-09 17:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907913002/20001
5 years, 10 months ago (2015-02-09 17:16:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907913002/40001
5 years, 10 months ago (2015-02-09 17:40:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/24411)
5 years, 10 months ago (2015-02-09 19:25:16 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/64c23723b3f3b67d0aab3e605645ae434f6affad Cr-Commit-Position: refs/heads/master@{#315376}
5 years, 10 months ago (2015-02-09 20:25:00 UTC) #12
teravest
5 years, 10 months ago (2015-02-09 20:25:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
64c23723b3f3b67d0aab3e605645ae434f6affad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698