runtime/bin/socket.h - Issue 907883002: Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.h

Issue 907883002: Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket.h

diff --git a/runtime/bin/socket.h b/runtime/bin/socket.h

index ff5444daa585f4546d8c2421e657565bd99e393b..ae59c5aa1d24390da12d77d3dedcbb0c223a660b 100644

--- a/runtime/bin/socket.h

+++ b/runtime/bin/socket.h

@@ -239,8 +239,6 @@ class Socket {

static int GetType(intptr_t fd);

static intptr_t GetStdioHandle(intptr_t num);

static void Close(intptr_t fd);

- static bool SetNonBlocking(intptr_t fd);

- static bool SetBlocking(intptr_t fd);

static bool GetNoDelay(intptr_t fd, bool* enabled);

static bool SetNoDelay(intptr_t fd, bool enabled);

static bool GetMulticastLoop(intptr_t fd, intptr_t protocol, bool* enabled);

« no previous file with comments | « runtime/bin/file_system_watcher_macos.cc ('k') | runtime/bin/socket_android.cc » ('j') | no next file with comments »