Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: runtime/bin/file_system_watcher_macos.cc

Issue 907883002: Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/socket.h » ('j') | runtime/bin/socket_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_system_watcher_macos.cc
diff --git a/runtime/bin/file_system_watcher_macos.cc b/runtime/bin/file_system_watcher_macos.cc
index 93177f2ea5a85372b9694a91fe68cd5e2687d2fe..2e24122b60b619c7a72a3b85d36c509badf9469b 100644
--- a/runtime/bin/file_system_watcher_macos.cc
+++ b/runtime/bin/file_system_watcher_macos.cc
@@ -264,8 +264,8 @@ class FSEventsWatcher {
Node* AddPath(const char* path, int events, bool recursive) {
int fds[2];
VOID_NO_RETRY_EXPECTED(pipe(fds));
- Socket::SetNonBlocking(fds[0]);
- Socket::SetBlocking(fds[1]);
+ FDUtils::SetNonBlocking(fds[0]);
+ FDUtils::SetBlocking(fds[1]);
char base_path[PATH_MAX];
realpath(path, base_path);
@@ -393,5 +393,3 @@ Dart_Handle FileSystemWatcher::ReadEvents(intptr_t id, intptr_t path_id) {
} // namespace dart
#endif // defined(TARGET_OS_MACOS)
-
-
« no previous file with comments | « no previous file | runtime/bin/socket.h » ('j') | runtime/bin/socket_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698