Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec

runtime/bin/socket_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/builtin.h"
 #include "bin/eventhandler.h"
 #include "bin/file.h"
@@ skipping 532 matching lines @@
   return true;
 }
 
 
 void Socket::Close(intptr_t fd) {
   ClientSocket* client_socket = reinterpret_cast<ClientSocket*>(fd);
   client_socket->Close();
 }
 
 
-static bool SetBlockingHelper(intptr_t fd, bool blocking) {
-  SocketHandle* handle = reinterpret_cast<SocketHandle*>(fd);
-  u_long iMode = blocking ? 0 : 1;
-  int status = ioctlsocket(handle->socket(), FIONBIO, &iMode);
-  if (status != NO_ERROR) {
-    return false;
-  }
-  return true;
-}
-
-
-bool Socket::SetNonBlocking(intptr_t fd) {
-  return SetBlockingHelper(fd, false);
-}
-
-
-bool Socket::SetBlocking(intptr_t fd) {
-  return SetBlockingHelper(fd, true);
-}
-
-
 bool Socket::GetNoDelay(intptr_t fd, bool* enabled) {
   SocketHandle* handle = reinterpret_cast<SocketHandle*>(fd);
   int on;
   socklen_t len = sizeof(on);
   int err = getsockopt(handle->socket(),
                        IPPROTO_TCP,
                        TCP_NODELAY,
                        reinterpret_cast<char *>(&on),
                        &len);
   if (err == 0) {
@@ skipping 134 matching lines @@
                     proto,
                     MCAST_LEAVE_GROUP,
                     reinterpret_cast<char *>(&mreq),
                     sizeof(mreq)) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)