Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 907793002: MidiManagerUsb should not trust indices provided by renderer. (Closed)

Created:
2 years, 9 months ago by yhirano
Modified:
2 years, 9 months ago
Reviewers:
Takashi Toyoshima
CC:
feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MidiManagerUsb should not trust indices provided by renderer. MidiManagerUsb::DispatchSendMidiData takes |port_index| parameter. As it is provided by a renderer possibly under the control of an attacker, we must validate the given index before using it. BUG=456516 Committed: https://crrev.com/5576cbc1d3e214dfbb5d3ffcdbe82aa8ba0088fc Cr-Commit-Position: refs/heads/master@{#315303}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Messages

Total messages: 17 (7 generated)
yhirano
2 years, 9 months ago (2015-02-09 02:14:48 UTC) #2
Takashi Toyoshima
lgtm https://codereview.chromium.org/907793002/diff/40001/media/midi/midi_manager_usb.cc File media/midi/midi_manager_usb.cc (right): https://codereview.chromium.org/907793002/diff/40001/media/midi/midi_manager_usb.cc#newcode46 media/midi/midi_manager_usb.cc:46: if (port_index >= output_streams_.size()) { Can you add ...
2 years, 9 months ago (2015-02-09 06:34:41 UTC) #3
yhirano
https://codereview.chromium.org/907793002/diff/40001/media/midi/midi_manager_usb.cc File media/midi/midi_manager_usb.cc (right): https://codereview.chromium.org/907793002/diff/40001/media/midi/midi_manager_usb.cc#newcode46 media/midi/midi_manager_usb.cc:46: if (port_index >= output_streams_.size()) { On 2015/02/09 06:34:41, Takashi ...
2 years, 9 months ago (2015-02-09 08:41:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907793002/60001
2 years, 9 months ago (2015-02-09 08:42:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on ...
2 years, 9 months ago (2015-02-09 10:42:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907793002/60001
2 years, 9 months ago (2015-02-09 10:51:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
2 years, 9 months ago (2015-02-09 11:02:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907793002/60001
2 years, 9 months ago (2015-02-09 14:01:19 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
2 years, 9 months ago (2015-02-09 15:13:36 UTC) #16
commit-bot: I haz the power
2 years, 9 months ago (2015-02-09 15:15:12 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5576cbc1d3e214dfbb5d3ffcdbe82aa8ba0088fc
Cr-Commit-Position: refs/heads/master@{#315303}

Powered by Google App Engine
This is Rietveld efc10ee0f