Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 907723004: Revert of [WebView] Add unique visual state request ids. (Closed)

Created:
5 years, 10 months ago by Ignacio Solla
Modified:
5 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebView] Add unique visual state request ids. (patchset #4 id:60001 of https://codereview.chromium.org/900303002/) Reason for revert: This is breaking some bots, see for example: https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/8923 https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%20(dbg)/builds/73663 The reason is: M D ST: Write to static field org.chromium.android_webview.AwContents.sNextVisualStateRequestId from instance method org.chromium.android_webview.AwContents.flushVisualState(AwContents$VisualStateFlushCallback) At AwContents.java Original issue's description: > [WebView] Add unique visual state request ids. > > Each flushVisualState request returns a unique id > that allows callers to match requests with callbacks. > The reasoning behind is to potentially allow clients > to reuse VisualStateFlushCallback objects to avoid > additional java allocations. > > BUG=455651 > > Committed: https://crrev.com/d011b93e7c8f966ba068b0c77c8a1400bdedee88 > Cr-Commit-Position: refs/heads/master@{#315304} TBR=boliu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455651 Committed: https://crrev.com/709e3c43d4287c5ae632b6614a1d3747fe21b47b Cr-Commit-Position: refs/heads/master@{#315321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -68 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +10 lines, -20 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java View 4 chunks +31 lines, -34 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -4 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ignacio Solla
Created Revert of [WebView] Add unique visual state request ids.
5 years, 10 months ago (2015-02-09 16:25:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907723004/1
5 years, 10 months ago (2015-02-09 16:27:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 16:28:21 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:28:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/709e3c43d4287c5ae632b6614a1d3747fe21b47b
Cr-Commit-Position: refs/heads/master@{#315321}

Powered by Google App Engine
This is Rietveld 408576698