ports/nacl-spawn/cli_main.c - Issue 907563002: Simplify cli_main

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ports/nacl-spawn/cli_main.c

Issue 907563002: Simplify cli_main (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright (c) 2014 The Native Client Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 */

	6

	7 /* Define a typical entry point for command line tools spawned by bash

	8 * (e.g., ls, objdump, and objdump). */

	9

	10 #include "ppapi_simple/ps_main.h"

	11 #include "nacl_main.h"

	12

	13 extern int nacl_main(int argc, char *argv[]);
	Sam Clegg 2015/02/17 18:22:45 This is declared in nacl_main.h already. This is declared in nacl_main.h already. gdeepti 2015/02/17 21:06:49 Acknowledged. Show quoted text On 2015/02/17 18:22:45, Sam Clegg wrote: > This is declared in nacl_main.h already. Acknowledged.
	14 void setup_nacl_spawn_env();
	Sam Clegg 2015/02/17 18:22:45 Declare this in nacl_main.h too. Also, can can ch Declare this in nacl_main.h too. Also, can can change the name of nacl_spawn comes first? nacl_spawn_setup_env()? That way any other functions we add to the global namespace can share the same prefix. gdeepti 2015/02/17 21:06:49 Done. Show quoted text On 2015/02/17 18:22:45, Sam Clegg wrote: > Declare this in nacl_main.h too. > > Also, can can change the name of nacl_spawn comes first? > > nacl_spawn_setup_env()? That way any other functions we > add to the global namespace can share the same prefix. Done.
	15

	16 int cli_main(int argc, char* argv[]) {

	17 setup_nacl_spawn_env();

	18 return nacl_main(argc, argv);

	19 }

	20

	21 PPAPI_SIMPLE_REGISTER_MAIN(cli_main)

OLD	NEW