Polish UI of bookmark app creation.

chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"
 
 #include "base/strings/string16.h"
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/geometry/safe_integer_conversions.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_source.h"
@@ skipping 153 matching lines @@
 
   gfx::Size image_size(kIconSize, kIconSize);
   gfx::ImageSkia image(new WebAppInfoImageSource(kIconSize, web_app_info_),
                        image_size);
   icon_image_view_->SetImageSize(image_size);
   icon_image_view_->SetImage(image);
   layout->AddView(icon_image_view_);
 
   title_tf_ = new views::Textfield();
   title_tf_->SetText(web_app_info_.title);
+  title_tf_->set_controller(this);
   layout->AddView(title_tf_);
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
   layout->StartRow(0, CONTENT_COLUMN_SET_ID);
   open_as_window_checkbox_ = new views::Checkbox(
       l10n_util::GetStringUTF16(IDS_BOOKMARK_APP_BUBBLE_OPEN_AS_WINDOW));
   open_as_window_checkbox_->SetChecked(web_app_info_.open_as_window);
   layout->AddView(open_as_window_checkbox_);
   layout->AddView(add_button_);
   layout->AddView(cancel_button_);
   layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
 
   AddAccelerator(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE));
+  UpdateAddButtonState();
 }
 
 views::View* BookmarkAppBubbleView::GetInitiallyFocusedView() {
   return title_tf_;
 }
 
 void BookmarkAppBubbleView::WindowClosing() {
   callback_.Run(user_accepted_, web_app_info_);
 }
 
@@ skipping 10 matching lines @@
   gfx::Size size(views::BubbleDelegateView::GetPreferredSize());
   size.SetToMax(gfx::Size(kMinBubbleWidth, 0));
   return size;
 }
 
 void BookmarkAppBubbleView::ButtonPressed(views::Button* sender,
                                           const ui::Event& event) {
   HandleButtonPressed(sender);
 }
 
+void BookmarkAppBubbleView::ContentsChanged(
+    views::Textfield* sender,
+    const base::string16& new_contents) {
+  DCHECK(sender == title_tf_);

[Lei Zhang, 2015/02/06 22:41:27]

DCHECK_EQ()

[benwells, 2015/02/07 03:17:38]

Done.

+  UpdateAddButtonState();
+}
+
 void BookmarkAppBubbleView::HandleButtonPressed(views::Button* sender) {
   if (sender == add_button_) {
     user_accepted_ = true;
-    web_app_info_.title = title_tf_->text();
+    web_app_info_.title = GetTrimmedTitle();
     web_app_info_.open_as_window = open_as_window_checkbox_->checked();
   }
 
   GetWidget()->Close();
 }
+
+void BookmarkAppBubbleView::UpdateAddButtonState() {
+  add_button_->SetEnabled(!GetTrimmedTitle().empty());
+}
+
+base::string16 BookmarkAppBubbleView::GetTrimmedTitle() {
+  base::string16 title(title_tf_->text());
+  base::TrimWhitespace(title, base::TRIM_ALL, &title);
+  return title;
+}