Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 907453004: Salvage the SampleApp portion of the ill-fated "nudge" CL (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Salvage the SampleApp portion of the ill-fated "nudge" CL Trying a different approach than nudging but this will still be useful. Committed: https://skia.googlesource.com/skia/+/c89f6fb29c38a7a52a40d585680cce590039d508

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -59 lines) Patch
M samplecode/SampleClipDrawMatch.cpp View 1 7 chunks +66 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
robertphillips
5 years, 10 months ago (2015-02-06 19:44:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907453004/1
5 years, 10 months ago (2015-02-06 19:45:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-06 19:45:34 UTC) #5
jvanverth1
lgtm https://codereview.chromium.org/907453004/diff/1/samplecode/SampleClipDrawMatch.cpp File samplecode/SampleClipDrawMatch.cpp (right): https://codereview.chromium.org/907453004/diff/1/samplecode/SampleClipDrawMatch.cpp#newcode39 samplecode/SampleClipDrawMatch.cpp:39: // The translation applied to the base AA ...
5 years, 10 months ago (2015-02-06 20:30:26 UTC) #7
robertphillips
https://codereview.chromium.org/907453004/diff/1/samplecode/SampleClipDrawMatch.cpp File samplecode/SampleClipDrawMatch.cpp (right): https://codereview.chromium.org/907453004/diff/1/samplecode/SampleClipDrawMatch.cpp#newcode39 samplecode/SampleClipDrawMatch.cpp:39: // The translation applied to the base AA rect ...
5 years, 10 months ago (2015-02-09 15:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907453004/20001
5 years, 10 months ago (2015-02-09 15:41:44 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:47:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c89f6fb29c38a7a52a40d585680cce590039d508

Powered by Google App Engine
This is Rietveld 408576698