Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 907403002: [strong] Introduce --use-strong flag (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Introduce --use-strong flag R=marja@chromium.org BUG= Committed: https://crrev.com/5cd84502bf1aadd42b3ccc90746f8bd79402d3b3 Cr-Commit-Position: refs/heads/master@{#26556}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added flag implication #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/compiler.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
rossberg
5 years, 10 months ago (2015-02-10 16:27:47 UTC) #1
marja
https://codereview.chromium.org/907403002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/907403002/diff/1/src/compiler.cc#newcode1363 src/compiler.cc:1363: construct_language_mode(FLAG_use_strict, FLAG_use_strong); This doesn't do the right thing; it ...
5 years, 10 months ago (2015-02-10 17:14:00 UTC) #2
rossberg
https://codereview.chromium.org/907403002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/907403002/diff/1/src/compiler.cc#newcode1363 src/compiler.cc:1363: construct_language_mode(FLAG_use_strict, FLAG_use_strong); On 2015/02/10 17:14:00, marja wrote: > This ...
5 years, 10 months ago (2015-02-10 17:19:25 UTC) #3
marja
lgtm
5 years, 10 months ago (2015-02-10 17:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907403002/20001
5 years, 10 months ago (2015-02-10 17:24:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 19:12:58 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:13:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cd84502bf1aadd42b3ccc90746f8bd79402d3b3
Cr-Commit-Position: refs/heads/master@{#26556}

Powered by Google App Engine
This is Rietveld 408576698