Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 907383003: MIPS64: Propagate DeoptInfo to cpu-profiler (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Propagate DeoptInfo to cpu-profiler Port 86cae1633caa31f2225b6932850fb13d3a21cf59 Original commit message: 1) Deoptimizer::Reason was replaced with Deoptimizer::DeoptInfo because it also has raw position. Also the old name clashes with DeoptReason enum. 2) c_entry_fp assignment call was added to EntryGenerator::Generate So we can calculate sp and have a chance to record the stack for the deopting function. btw it makes the test stable. 3) new kind of CodeEvents was added to cpu-profiler 4) GetDeoptInfo method was extracted from PrintDeoptLocation. So it could be reused in cpu profiler. BUG=452067 LOG=n Committed: https://crrev.com/661668f7ab9011720fe44239d114ec6fb09a72f2 Cr-Commit-Position: refs/heads/master@{#26554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/mips64/deoptimizer-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-10 17:56:56 UTC) #2
dusmil.imgtec
LGTM.
5 years, 10 months ago (2015-02-10 17:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907383003/1
5 years, 10 months ago (2015-02-10 18:00:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 19:10:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:10:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/661668f7ab9011720fe44239d114ec6fb09a72f2
Cr-Commit-Position: refs/heads/master@{#26554}

Powered by Google App Engine
This is Rietveld 408576698