Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 907353003: Remove obsolete method ProfileTree::AddPathFromStart and the corresponding test. (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete method ProfileTree::AddPathFromStart and the corresponding test. BUG= LOG=n Committed: https://crrev.com/754cc1a9e45e5ff71a65103d4923fd20792420a9 Cr-Commit-Position: refs/heads/master@{#26565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -96 lines) Patch
M src/profile-generator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 4 chunks +19 lines, -77 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
loislo
PTAL
5 years, 10 months ago (2015-02-10 15:45:17 UTC) #2
alph
lgtm
5 years, 10 months ago (2015-02-10 15:54:45 UTC) #3
Sven Panne
lgtm
5 years, 10 months ago (2015-02-11 07:25:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907353003/1
5 years, 10 months ago (2015-02-11 07:25:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 07:27:04 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 07:27:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/754cc1a9e45e5ff71a65103d4923fd20792420a9
Cr-Commit-Position: refs/heads/master@{#26565}

Powered by Google App Engine
This is Rietveld 408576698