Issue 907353002: Revert of Added behind link_core_modules_separately flag to gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 907353002: Revert of Added behind link_core_modules_separately flag to gyp files. (Closed)

Created:
5 years, 10 months ago by caseq

Modified:
5 years, 10 months ago

Reviewers:
haraken, tasak

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Added behind link_core_modules_separately flag to gyp files. (patchset #2 id:20001 of https://codereview.chromium.org/907303002/) Reason for revert: Reverting as the primary suspect of android build failure: http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/40331/steps/compile/logs/stdio Original issue's description: > Added behind link_core_modules_separately flag to gyp files. > > Also did the followings: > - added webcore_shared build target to core.gyp, > - moved some sources from core.gyp to core.gypi. So core.gyp uses variables defined in core.gypi. > - updated modules.gyp to see the flag, > - updated web.gyp to see the flag, > > > BUG=358074 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189893 TBR=haraken@chromium.org,tasak@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189896

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -382 lines)			Patch
M	Source/build/features.gypi	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/core/core.gyp	View	2 chunks	+106 lines, -189 lines	0 comments	Download
M	Source/core/core_generated.gypi	View	1 chunk	+0 lines, -130 lines	0 comments	Download
M	Source/modules/modules.gyp	View	3 chunks	+2 lines, -28 lines	0 comments	Download
M	Source/web/web.gyp	View	6 chunks	+7 lines, -26 lines	0 comments	Download

Total messages: 4 (0 generated)

caseq

Created Revert of Added behind link_core_modules_separately flag to gyp files.

5 years, 10 months ago (2015-02-10 13:20:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907353002/1

5 years, 10 months ago (2015-02-10 13:20:49 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189896

5 years, 10 months ago (2015-02-10 13:21:16 UTC) #3

Message was sent while issue was closed.

LGTM