Issue 907333002: Apply an upstream patch for a resource leak in BiDi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 907333002: Apply an upstream patch for a resource leak in BiDi (Closed)

Created:
5 years, 10 months ago by jungshik at Google

Modified:
5 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Apply an upstream patch for a resource leak in BiDi Blink does not use ICU's Bidi API, but it may in the future. Moreover, Chrome UI does use ubidi API. Replace the current bidi.patch (that I should have deleted because it's already a part of ICU 54.1 and is not applied) with a new one. upstream bug: http://bugs.icu-project.org/trac/ticket/11177 BUG=428145 TEST=None R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/3a9ccbc5be8ea0732020167dbedb493e5459b289

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -97 lines)			Patch
M	README.chromium	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	patches/bidi.patch	View	1 chunk	+36 lines, -93 lines	0 comments	Download
M	source/common/ubidi.c	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

jungshik at Google

5 years, 10 months ago (2015-02-10 18:56:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a9ccbc5be8ea0732020167dbedb493e5459b289 (presubmit successful).