Implemented DeviceStatusCollector::GetDeviceSessionStatus()

chrome/browser/chromeos/login/users/mock_user_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/mock_user_manager.h"
 
 #include "base/task_runner.h"
 #include "chrome/browser/chromeos/login/users/fake_supervised_user_manager.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 
@@ skipping 90 matching lines @@
 
 user_manager::User* MockUserManager::CreatePublicAccountUser(
     const std::string& email) {
   ClearUserList();
   user_manager::User* user = user_manager::User::CreatePublicAccountUser(email);
   user_list_.push_back(user);
   ProfileHelper::Get()->SetProfileToUserMappingForTesting(user);
   return user_list_.back();
 }
 
+user_manager::User* MockUserManager::CreateKioskAppUser(
+    const std::string& email) {
+  ClearUserList();
+  user_manager::User* user = user_manager::User::CreateKioskAppUser(email);

[bartfab (slow), 2015/02/11 17:28:42]

Nit: s/user_manager::User* user/user_manager::User* const user/

[Andrew T Wilson (Slow), 2015/02/12 15:15:38]

Removed

+  user_list_.push_back(user);

[bartfab (slow), 2015/02/11 17:28:43]

Nit: Why not push_back() the User object as it is created, and then refer to it
via user_list_.back() throughout? This avoids the short stretch of code where
|user| is owned via a raw pointer.

[Andrew T Wilson (Slow), 2015/02/12 15:15:38]

Done.

+  ProfileHelper::Get()->SetProfileToUserMappingForTesting(user);
+  return user_list_.back();
+}
+
 void MockUserManager::AddUser(const std::string& email) {
   user_manager::User* user = user_manager::User::CreateRegularUser(email);
   user_list_.push_back(user);
   ProfileHelper::Get()->SetProfileToUserMappingForTesting(user);
 }
 
 void MockUserManager::ClearUserList() {
   // Can't use STLDeleteElements because of the protected destructor of User.
   user_manager::UserList::iterator user;
   for (user = user_list_.begin(); user != user_list_.end(); ++user)
     delete *user;
   user_list_.clear();
 }
 
 }  // namespace chromeos