Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 907303002: Added behind link_core_modules_separately flag to gyp files. (Closed)

Created:
5 years, 10 months ago by tasak
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added behind link_core_modules_separately flag to gyp files. Also did the followings: - added webcore_shared build target to core.gyp, - moved some sources from core.gyp to core.gypi. So core.gyp uses variables defined in core.gypi. - updated modules.gyp to see the flag, - updated web.gyp to see the flag, BUG=358074

Patch Set 1 #

Patch Set 2 : Moved link_core_modules_separetely to features.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -115 lines) Patch
M Source/build/features.gypi View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 2 chunks +189 lines, -106 lines 0 comments Download
M Source/core/core_generated.gypi View 1 chunk +130 lines, -0 lines 0 comments Download
M Source/modules/modules.gyp View 1 3 chunks +28 lines, -2 lines 0 comments Download
M Source/web/web.gyp View 1 6 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tasak
Would you review this CL?
5 years, 10 months ago (2015-02-10 10:30:16 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-10 11:06:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907303002/20001
5 years, 10 months ago (2015-02-10 12:40:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=189893
5 years, 10 months ago (2015-02-10 12:43:53 UTC) #7
caseq
5 years, 10 months ago (2015-02-10 13:20:28 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/907353002/ by caseq@chromium.org.

The reason for reverting is: Reverting as the primary suspect of android build
failure:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28d....

Powered by Google App Engine
This is Rietveld 408576698