Issue 907203002: Switch feedback consent dialog to use oauth2_api_impl.

Issue 907203002: Switch feedback consent dialog to use oauth2_api_impl. (Closed)

Created:
5 years, 10 months ago by Jamie

Modified:
5 years, 10 months ago

Reviewers:
garykac

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Switch feedback consent dialog to use oauth2_api_impl. This was broken by https://codereview.chromium.org/840023004/ and was not caught because we don't auto-generate feedback_consent.html, nor do we run it through jscompile. BUG=457044 Committed: https://crrev.com/c1f445911d153d2e59b6c917295c202eda4cfb91 Cr-Commit-Position: refs/heads/master@{#315586}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	remoting/webapp/app_remoting/html/feedback_consent.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	remoting/webapp/app_remoting/js/feedback_consent.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Jamie

PTAL. In the longer term, I think this highlights the need to generate all of ...

5 years, 10 months ago (2015-02-10 00:24:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907203002/1

5 years, 10 months ago (2015-02-10 16:12:14 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 17:50:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c1f445911d153d2e59b6c917295c202eda4cfb91
Cr-Commit-Position: refs/heads/master@{#315586}