Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 907143002: Deflake and reenable top controls tests. (Closed)

Created:
5 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake and reenable top controls tests. Windows bots had trouble with the expectations in the animation loops. Because of floating point inaccuracies, the top controls offset could be exactly the same during the last two frames of the animation, because the shown ratio was just off the minimum and that delta disappeared when multiplying by the height. This switches to checking the ratio itself, which should match the same value that the animation system uses to check if the next frame is needed. BUG=456617 Committed: https://crrev.com/2c00a9a6c962300efed56e630aabbf49144c2d64 Cr-Commit-Position: refs/heads/master@{#315416}

Patch Set 1 #

Patch Set 2 : Reupload same patch for another try run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M cc/input/top_controls_manager_unittest.cc View 10 chunks +27 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aelias_OOO_until_Jul13
Hi David, PTAL.
5 years, 10 months ago (2015-02-09 20:54:05 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-09 21:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907143002/20001
5 years, 10 months ago (2015-02-09 22:01:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 22:42:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:43:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c00a9a6c962300efed56e630aabbf49144c2d64
Cr-Commit-Position: refs/heads/master@{#315416}

Powered by Google App Engine
This is Rietveld 408576698